Repository navigation
Disallow DOCTYPE in TestReader XML parser - #1252
Open
Keerthana-64 wants to merge 1 commit into
Open
Keerthana-64 wants to merge 1 commit into
Keerthana-64 wants to merge 1 commit into
Conversation
Test files do not require DOCTYPE. Configure the TestReader SAXBuilder to reject it, as GMLReader and KMLReader now do. Signed-off-by: Keerthana KT <keerthana@labs.digiscrypt.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestReader.createTestRunon master, for a test file that declares an external entity:Follow up to #1244.
TestReaderis the remaining XML parser in the repo without that configuration, and it is what JTSTestRunner and the TestBuilder use to open XML test files, which are regularly posted in issues here. A<!DOCTYPE run SYSTEM "http://...">is also fetched on master (checked against a local HTTP server: 1 request before, 0 after).Test files do not need a DOCTYPE (none of the XML test files in the repo have one, and
XMLTestWriterdoes not write one), so theSAXBuildernow setsdisallow-doctype-decl. If a SAX driver does not recognize the feature, JDOM rejects the file instead of parsing it without the setting.testExternalGeometryNotIncludedinTestReaderTestfails on master and passes with the change, andmvn clean installpasses.KMLReaderExamplealso uses a defaultXMLReader, but it only reads a hard-coded local path, so I left it as is.