Repository navigation
[vendor] Update the lowRISC IPs - #2557
Open
SamuelRiedel wants to merge 6 commits into
Open
SamuelRiedel wants to merge 6 commits into
SamuelRiedel wants to merge 6 commits into
Conversation
SamuelRiedel
marked this pull request as draft
November 2, 2026 17:10
OpenTitan has the SRAM configuration interface changes and no longer needs bus_params_pkg in dv_lib. Also vendor the new dv_base_agent core that dv_lib depends on and refresh the cov_merge.tcl patch. Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
Update code from upstream repository https://github.com/lowRISC/opentitan to revision 1e061997389b1c257043b0dbd2388a19a6c2f6f1 * [prim,kmac,spi_host,rtl] Fix rst_n arguments to ASSERT calls (Rupert Swarbrick) * [dv,dv_utils] Only change severity when a report catcher rule matches (Harry Callahan) * [prim_lfsr] Override polynomial for 102-bit LFSR (Hakim Filali) * [prim,rtl] Add redundant prim_fifo_sync (Pascal Nasahl) * [prim] Fix missing FuseSoC dependencies and split sync primitive cores (Samuel Riedel) * [prim] Remove unused prim_assert.sv includes and dependencies (Samuel Riedel) * [hw,csrng] Make GEN counter overflow (Hakim Filali) * [secded] Re-generate files following changes (Elliot Baptist) * [secded] Improve SECDED generation (Elliot Baptist) * [prim] Add `ceil_udiv` to `prim_util_pkg` (Andreas Kurth) * [dvsim] Load the Verdi FSDB dumper for Xcelium (James McCorrie) * [prim] Declare scan_clk_i of prim_pad_wrapper as unused (Pascal Etterli) * [prim/lint] Add a verilator lint waiver for warning in prim_diff_decode (Pirmin Vogel) * [dv] Make mem_bkdr_util::get_full_path/get_bit_slice_path virtual (Sharon Topaz) * [dv,xcelium] Enable Constant Object Marking in coverage flow (Harry Callahan) * [reggen] Regenerate top-level register RTL files (Adrian Lees) * [reggen] Support a list of reinit signals (Adrian Lees) * [aes,dv] Allow aes_reseed_vseq resets when passing new sideload key (Rupert Swarbrick) * [dv] Only sort dv_base_reg_block::m_mem_ranges if nonempty (Rupert Swarbrick) * [alert_handler,dv] Split the alert and escalation agents (Rupert Swarbrick) * [hw/dvsim] Add slang to dvsim (luwuethri) * [dv,mem_bkdr_util] Fix ECC recompute bound in load_mem_from_file (Martin Velay) * [dv,doc] Dramatic improvements to dv/sv/csr_utils/README.md (Rupert Swarbrick) * [dv,mem_bkdr_util] Add words_per_row/num_bit_slices/custom-path support (Michael Gautschi) * [dvsim,vcs] Allow warning -Wincompatible-pointer-types (Michael Gautschi) * [dv,mem_bkdr_util] Support file ops on tiled memories (Andreas Kurth) * [dv] Teach cip_base_scoreboard about allowed fetches (Rupert Swarbrick) * [rram_macro,fusesoc] Make RRAM macro a virtual module (Michael Gautschi) * [dv] Report the exclusions behind a coverage score (martin-velay) * [dv] Drop prim_secded data_i excl for Xcelium (martin-velay) * [hw,prim] Drop fileset_partner for mappings (Andreas Kurth) * [prim] Add a virtual core for prim libraries (Andreas Kurth) * [prim,doc] Document the dvsim FuseSoC options (Andreas Kurth) * [dv] Remove +num_csr_chunks / +test_csr_chunk (Rupert Swarbrick) * [dv] Re-order csr_aliasing_seq to use out-of-block definitions (Rupert Swarbrick) * [dv] Speed up csr_aliasing_seq (Rupert Swarbrick) * [dv] Split csr_aliasing_seq into a separate file (Rupert Swarbrick) * [dv] Check CSR-fetch permission per reg block (Andreas Kurth) * [flash_ctrl,rtl] remove ipgen files for flash_ctrl (Michael Gautschi) * [trivium] Expose the internal state of Trivium/Bivium (Pascal Etterli) * [prim,rtl] Tie off unused nonce bits when address scrambling is off (Thomas Benz) * [dv] Improve names for functions that set reg block base address (Rupert Swarbrick) * [dv] Slightly expand out dv_base_reg_block::set_base_addr (Rupert Swarbrick) * [dv] Add a dv_base_env_cfg::set_is_active function (Rupert Swarbrick) * [dv] Remove dv_base_reg_block::csr_addrs and its uses (Rupert Swarbrick) * [dv] Pass widths to dv_base_reg_block::build (Rupert Swarbrick) * [dv,chip] Add inherit_ral_models flag (Rupert Swarbrick) * [dv] Fix backwards error message in csr_rd (Rupert Swarbrick) * [dv] Fix the broken "memoization" for dv_base_reg_block::mem_ranges (Rupert Swarbrick) * [alert,fpv] Replace nonsense AlertPingIgnored_A assertion (Rupert Swarbrick) * [prim,fpv] Waive impossible cover items from async alert fpv (Rupert Swarbrick) * [prim,rtl] Use effective_rst_n in SyncReqAck(HoldReq/AckAckNeedsReq) (Rupert Swarbrick) * [dv] Remove argument from DV_GET_ENUM_PLUSARG (Rupert Swarbrick) * [dv] Remove the stringification from 3rd arg of DV_GET_ENUM_PLUSARG (Rupert Swarbrick) * [dv] Make a csr_utils error message slightly more informative (Rupert Swarbrick) * [hw,prim] Add assertions for undefined same row writes (Hakim Filali) * [hw,ram] Remove dependencies on unused prim_xilinx_pkgs (Hakim Filali) * [rtl, prim] Always write whole ram rows in ram prims (Hakim Filali) * [rtl, prim] Copy RAM prims to prim_xilinx folder (Hakim Filali) * [dv] Move the code that sets dv_base_env_cfg::ral (Rupert Swarbrick) * [dv] Make dv_base_env_cfg::ral_model_names a set (Rupert Swarbrick) * [dv] Fix string in error message (Rupert Swarbrick) * [dv] Remove unused dv_utils_pkg::get_masked_data (Rupert Swarbrick) * [dv] Make dv_base_reg depend on prim:mubi_pkg, not prim:mubi (Rupert Swarbrick) * [top,rtl] Generalize SRAM configuration interfaces (Thomas Benz) * [rtl,fpga] Re-activate the ROM FPGA loader endpoint (Alex Jones) * [fusesoc] Move away from `fileset_partner` to select `ast_pkg` (Andreas Kurth) * [top, prim_pad_wrapper] Add pad orientation parameters (Pirmin Vogel) * [lint] Waive errors and warnings flagged by more recent tool versions (Pirmin Vogel) * [sw] Upgrade toolchain to LLVM 21 (Luís Marques) * [hw, otbn] Add the top level implementation of the mask accelerator (Hakim Filali) * [rtl, prim] Explicitly define length of PossibleActions (Hakim Filali) * [prim_ram_1p_scr] Support scrambling of non-power-of-2 sized memories (Pirmin Vogel) * [dv] Alter dv_base_env_cfg to avoid dv_lib using bus_params_pkg (Rupert Swarbrick) * [doc] Add V2S scoping to V2 checklist (Rupert Swarbrick) * [doc] add DOC_PARAM_IP to D3 checklist (Pirmin Vogel) * [dv] Split reactive agents from dv_base_agent (Rupert Swarbrick) * [rtl,fpga] Add and integrate FPGA-only memory backdoor loader IP (Alex Williams) * [chip,dv] Remove macro with only one user (Rupert Swarbrick) * [dv] Fix address mask computation in get_normalized_addr (Rupert Swarbrick) * Update hw/ip/prim/rtl/prim_fifo_async_simple.sv (nsw-lowrisc) * [prim/rtl] Improve prim_fifo_async_simple DFT for rv_dm and lc_ctrl (Neil Webb) * [dv] Optimize reseed values for all blocks/tops (martin-velay) * [doc] Move badge domain from dashboards to dashboard.reports (Tye Buckingham) * [dv] Add a "chip_level" fusesoc flag (Rupert Swarbrick) * [alert,fpv] Strengthen AlertHs_A in prim_alert_rxtx_assert_fpv (Rupert Swarbrick) * [dv] Correct documentation about reset tracking in csr_utils (Rupert Swarbrick) * [dv] Define csr_excluded to balance iterations in csr_hw_reset_seq (Rupert Swarbrick) * [dv] Define a csr_excluded function in csr_base_seq (Rupert Swarbrick) * [dv] Split csr_hw_reset_seq into its own file (Rupert Swarbrick) * [dv] Split out max_num_test_csrs explicitly in csr_base_seq (Rupert Swarbrick) * [dv,doc] Add detailed documentation to csr_base_seq.sv (Rupert Swarbrick) * [dv,csr_utils] Split csr_base_seq into its own file (Rupert Swarbrick) * [dv] Allow a test to configure an env_cfg before cfg.initialize() (Rupert Swarbrick) * [dv] Extend memory backdoor data width limit (Sharon Topaz) * [dv] Decouple mem_bkdr_util row width and uvm_hdl_data_t (Rupert Swarbrick) * [doc] Update various dvsim references (Harry Callahan) * [util,dvsim] Remove util/dvsim (Harry Callahan) * [dv] Extract the dv_base_agent files into their own core and package (Rupert Swarbrick) * [dv] Rationalise dv_base_driver reset tracking (Rupert Swarbrick) * [aes/dv] Add RAL type override to allow separating GCM and non-GCM DV (Pirmin Vogel) * [hw/otbn] Add new HPC gadgets (Hakim Filali) * [prim/rtl] Improve prim_fifo_async_simple for rv_dm and lc_ctrl (Neil Webb) * [prim/rtl] Explicitly assign values to FSM states in prim_sync_reqack (Neil Webb) * [prim_xilinx] Use typeless parameter for MemInitFile (Ray Lau) * [dv] Allow a cfg to be passed directly to dv_base_agent (Rupert Swarbrick) * [hw,prim] Add new prim_inv (Hakim Filali) * [prim] Add prim_flop_x module to wrap different prim_flop variants (Pirmin Vogel) * [dv] Remove csr_base_addr argument from dv_base_env_cfg::initialize (Rupert Swarbrick) * [dv] Add "Monitor" to if_mode_e (Rupert Swarbrick) * [script] Fix Xcelium ranking report generation (martin-velay) * [script] Remove double entry of exclusion (martin-velay) * [dv] Remove unused dv_vif_wrap class (Rupert Swarbrick) * [dv] Check frequency later in clk_rst_if (Rupert Swarbrick) * [dv] Avoid null pointer dereference in dv_base_scoreboard (Rupert Swarbrick) * [chip, dv] Unrecognized hierarchical path argument in task (Kinza Qamar) * [verilator] Support loading binary files (Chris Frantz) * [dv] Get rid of dv_base_reg_field::set_original_access (Rupert Swarbrick) * [dv] Add some documentation to dv_base_agent (Rupert Swarbrick) * [dv] Add a very minor documentation note to dv_base_agent_cov (Rupert Swarbrick) * [dv] Add documentation comments to dv_base_agent_cfg (Rupert Swarbrick) * [dv] Remove unnecessary empty driver run_phase implementations (Rupert Swarbrick) * [dv] Document tasks in dv_base_driver (Rupert Swarbrick) * [dv] Allow dv_base_env to work if clk_rst_ifs are already in cfg (Rupert Swarbrick) * [dv] Remove the IfName parameter from clk_rst_if (Rupert Swarbrick) * [prim_subreg_shadow] Prevent X-propagation for W1S/W0C shadow registers (Pirmin Vogel) * [dv] Remove two unused flags from dv_base_mem (Rupert Swarbrick) * [prim_subreg_shadow] Align remaining prim_subreg[_arb] instantiations (Pirmin Vogel) * [prim_subreg_shadow] Reduce area of shadow register implementation (Pirmin Vogel) * [dv] Teach dv_base_test to accept an env_cfg object from db (Rupert Swarbrick) * [fi] Add README for Z01X tooling (Pascal Nasahl) * [flash_ctrl/fi] Add VC-Z01X FI analysis support to flash_ctrl (Pascal Nasahl) * [dvsim/python] Add run_opts_fi_sim (Pascal Nasahl) * [dvsim] Enable opts for post_build commands (Pascal Nasahl) * [dv] Allow dv_base_env_cfg with a templated RAL type (Rupert Swarbrick) * [dv] Make creation of CFG_T object more general in dv_base_test (Rupert Swarbrick) * [rv_dm,dv] Fix bug in rv_dm_csr_mem_rw_with_rand_reset (Rupert Swarbrick) * [otbn,fpv] Get the OTBN SecCm FPV tests working properly (Rupert Swarbrick) * [prim,xilinx] add missing dependency to prim_const (Michael Gautschi) * [prim,rtl] use prim_const in sdc_example (Michael Gautschi) * [prim,rtl] add prim_sec_anchor_const (Michael Gautschi) * [prim,rtl] new prim_const cells (Michael Gautschi) * [dv] Cleanup prints in sim.mk (Harry Callahan) * [dv] Add dedicated python script for building sim sw collateral (Harry Callahan) * [alert,fpv] Slightly rephrase a couple of liveness assertions (Rupert Swarbrick) * [alert,fpv] Add stopats and assertions to hit parasitic FSM states (Rupert Swarbrick) * [alert,fpv] Make AlertCheck1_A actually true for async alerts (Rupert Swarbrick) * [alert,fpv] Describe the AlertCheck1_A assertion more clearly (Rupert Swarbrick) * [alert,fpv] Simplify AlertCheck1_A in rxtx async assert (Rupert Swarbrick) * [alert,fpv] Dramatically simplify code for two liveness assertions (Rupert Swarbrick) * [alert,fpv] Rather simplify some of the async alert code assertions (Rupert Swarbrick) * [alert,fpv] Rephrase some liveness properties with s_eventually (Rupert Swarbrick) * [alert,fpv] Rephrase the handshake assertion in async rxtx alert fpv (Rupert Swarbrick) * [alert,fpv] Document handshakes better in async alert fpv (Rupert Swarbrick) * [alert,fpv] Minor layout tidy-ups in async alert fpv (Rupert Swarbrick) * [prim,fpv] Add a "helper assertion" for prim_diff_decode (Rupert Swarbrick) * [dv] Update dvsim shell path (Douglas Reis) * [prim_gf_mult] Allow forwarding 0 instead of Operand A while busy (Pirmin Vogel) * [prim_gf_mult] Add ack_pre_o output (Pirmin Vogel) * [mem_bkdr_util, dv] fix write128 function (Michael Gautschi) * [prim/lint] Fix lint for prim_arbiter_ppc with N=1 (Pirmin Vogel) * [dv] Reorder dv_base_env_cfg and add documentation comments (Rupert Swarbrick) * [dv] Move use_jtag_dmi to chip_env_cfg (Rupert Swarbrick) * [dv] Move will_reset functionality to cip_base_env_cfg (Rupert Swarbrick) * [dv] Move en_scb_ping_chk to cip_base_env_cfg (Rupert Swarbrick) * [dv] Move en_scb_tl_err_chk to cip_base_env_cfg (Rupert Swarbrick) * [dv] Make dv_base_env_cfg::create_ral_models safe to call twice (Rupert Swarbrick) * [dv] Move compute_*mapped_addr_ranges into set_base_addr (Rupert Swarbrick) * [dv] Make dv_base_reg_block::compute_unmapped_addr_ranges idempotent (Rupert Swarbrick) * [dv] Make dv_base_reg_block::compute_mapped_addr_ranges idempotent (Rupert Swarbrick) * [dv] Make dv_base_reg_block::compute_mem_addr_ranges idempotent (Rupert Swarbrick) * [dv] Make dv_base_reg_block::compute_csr_addrs idempotent (Rupert Swarbrick) * [dv] Make bit_toggle_cg_wrap name compulsory (Rupert Swarbrick) * [dv] Tiny tidy-up in dv_base_env_cov (Rupert Swarbrick) * [dv] Get rid of unused path arg to bit_toggle_cg_wrap constructor (Rupert Swarbrick) * [dv] Extract bit_toggle_cg_wrap from dv_base_env_cov (Rupert Swarbrick) * [dv] Use correct uvm_object_utils macro for mubi32_cov (Rupert Swarbrick) * [fpv,darjeeling] Teach rxtx alert checks to support SkewCycles = 3 (Rupert Swarbrick) * [dv/push_pull] Make sure that ack_o is always reset (Florian Glaser) * [csrng/dv] Align dv with RTL changes (Florian Glaser) Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
dv_lib moved the agent base classes into dv_base_agent_pkg, dropped the unused request and response ports from dv_base_monitor and replaced dv_base_env_cfg::initialize with initialize_ral. Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
OpenTitan no longer contains dvsim, so it is no longer part of the vendored lowrisc_ip. Install it from PyPI at the version OpenTitan pins, in both python-requirements.txt and the nix Python environment. The nix environment needs pyyaml 6.0.2 for it. Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
SamuelRiedel
force-pushed
the
update-lowrisc-ip
branch
from
November 19, 2026 12:54
00aa7cc to
2f33be1
Compare
SamuelRiedel
marked this pull request as ready for review
November 19, 2026 13:12
Contributor
Author
|
Now that lowRISC/opentitan#32127 is merged in master, this PR is ready. |
gautschimi
approved these changes
Nov 19, 2026
gautschimi
left a comment
Contributor
There was a problem hiding this comment.
Looks good. This vendors the OpenTitan prims into ibex.
For OpenTitan nothing changes because OpenTitan uses its own prims.
For ibex I think it's good to get rid of all the patches.
The state after commit 2,3,4 might be broken. I don't insist that we squash things together. I think it's clearer to keep the individual commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendor in the latest version of lowrisc_ip from OpenTitan:
This is WIP as we are also fixing prims in OT first: lowRISC/opentitan#32127