Repository navigation
[rtl] Protect Ibex clock gate against faults - #2565
Merged
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document. By submitting this pull request comment, I am hereby confirming my acceptance of the terms of the CLA Document and my agreement to be legally bound by its terms. |
vogelpi
reviewed
Nov 13, 2026
vogelpi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR and sorry for the review delay @nasahlpa . I think we should build a mini-lockstep running on the ungated clock for the core_busy_o signal only. If I understand correctly, the current implementation is not robust. But maybe best to discuss in person on Monday.
| When Ibex is configured with the SecureIbex parameter, the core clock gate is checked. | ||
| A fault on the clock enable logic or on the clock gate could stop the core clock while the core should be running. | ||
| As both cores of the dual core lockstep and the lockstep comparison are clocked by the gated clock, the lockstep cannot detect this. | ||
| To mitigate this thread, the clock enable is recomputed from an independent copy of the core busy register and the gated clock is observed using a toggle flop that is sampled in the ungated clock domain. |
Faulting the clock enable (gate) signal is not detected by the lockstep comparison as both cores are then halted. To protect against this FI threat, redundantly compute the clock enable signal and check whether the gated clock is running as expected or not. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
nasahlpa
force-pushed
the
ibex_clock_gate_protection
branch
from
November 19, 2026 09:16
a9557f0 to
6de6b08
Compare
vogelpi
approved these changes
Nov 19, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 19, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faulting the clock enable (gate) signal is not detected by the lockstep comparison as both cores are then halted.
To protect against this FI threat, redundantly compute the clock enable signal and check whether the gated clock is running as expected or not.