Skip to content

[proj] V1 signoff for rv_timer DV block - #799

Open
tchilikov-semify wants to merge 2 commits into
lowRISC:mainfrom
tchilikov-semify:v1_signoff_rv_timer
Open

tchilikov-semify wants to merge 2 commits into
lowRISC:mainfrom
tchilikov-semify:v1_signoff_rv_timer

Conversation

@tchilikov-semify

Copy link
Copy Markdown
Collaborator

No description provided.

@martin-velay martin-velay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the 1st commit: Could the path-fix commit get a short body saying what it fixes? Before it, DVSim ran rv_timer with no testplan, so the dashboard had no testpoint mapping for the Timer.

Comment thread doc/proj/rv_timer.md Resolved

@KinzaQamar KinzaQamar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the comment I wrote

Comment thread doc/proj/rv_timer.md Resolved
The testplan path in rv_timer_sim_cfg.hjson and the imports in
rv_timer_testplan.hjson still pointed at their OpenTitan locations.
DVSim found no testplan and ran rv_timer with an empty one, so the
dashboard had no testpoint mapping for the Timer.

Point them, the RAL spec and the VCS coverage exclusion files at the
vendored copies, and record the change as patch 0003.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants