Repository navigation
[proj] V1 signoff for rv_timer DV block - #799
Open
tchilikov-semify wants to merge 2 commits into
Open
tchilikov-semify wants to merge 2 commits into
tchilikov-semify wants to merge 2 commits into
Conversation
tchilikov-semify
requested review from
KinzaQamar,
marnovandermaas and
martin-velay
November 12, 2026 12:26
martin-velay
left a comment
Contributor
There was a problem hiding this comment.
On the 1st commit: Could the path-fix commit get a short body saying what it fixes? Before it, DVSim ran rv_timer with no testplan, so the dashboard had no testpoint mapping for the Timer.
KinzaQamar
approved these changes
Nov 13, 2026
KinzaQamar
left a comment
Contributor
There was a problem hiding this comment.
LGTM, apart from the comment I wrote
The testplan path in rv_timer_sim_cfg.hjson and the imports in rv_timer_testplan.hjson still pointed at their OpenTitan locations. DVSim found no testplan and ran rv_timer with an empty one, so the dashboard had no testpoint mapping for the Timer. Point them, the RAL spec and the VCS coverage exclusion files at the vendored copies, and record the change as patch 0003.
tchilikov-semify
force-pushed
the
v1_signoff_rv_timer
branch
from
November 18, 2026 09:48
c549381 to
8ff4e34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.