Repository navigation
Debug module disable - #802
marnovandermaas wants to merge 7 commits into
Conversation
This just adds it to the top and doesn't yet disable the debug module with it. Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
This is in preparation of properly tieing off the debug module when it is disabled. Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
This connects the debug enable to the new debug module top and masks all the inputs to known values. Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
If debug is disabled since last reset then all output should be stable and known values. Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
raylau1
left a comment
There was a problem hiding this comment.
Some comments on the RTL.
| // Debug Module AXI Adapter | ||
| axi_adapter #( | ||
| .CVA6Cfg ( CVA6Cfg ), | ||
| .DATA_WIDTH ( XLen ), |
| .axi_req_o (axi_host_req_o), | ||
| .axi_resp_i (axi_host_resp_i) | ||
| .axi_resp_i (axi_host_resp_masked) |
There was a problem hiding this comment.
Masking the response but not the request can cause the xbar to see req.valid_in = 1 and resp.ready_out = 1 for incoming channels, therefore constantly accept the same channel transfer until buffers fill up. For xbar outgoing channels, it sees req.ready_in = 1 and resp.valid_out = 1, so transfers are lost after masking. Please also mask the request to prevent transfer duplication/loss.
| .busy_o ( ), | ||
| .axi_req_i (axi_device_req_i), | ||
| .axi_req_i (axi_device_req_masked), | ||
| .axi_resp_o (axi_device_resp_o), |
There was a problem hiding this comment.
Same as the axi_host interface, please also mask resp to prevent transfer duplication/loss.
| // Non-debug module reset. | ||
| output logic ndmreset_req_o, | ||
| input logic ndmreset_ack_i, | ||
|
|
||
| // Request to processor core. | ||
| output logic debug_req_o |
There was a problem hiding this comment.
I think ndmreset_req_o and debug_req_o should also be masked when dm is disabled. As for td_o and td_en_o I'll let you decide.
This PR adds a debug enable signal to the Mocha top. This debug enable signal ties off the inputs to the debug module and there are formal assertions to prove the output is stable when it is disabled.