Skip to content

[doc] Add wrapper feature documentation - #7

Merged
raylau1 merged 1 commit into
lowRISC:mainfrom
raylau1:add-spec
Nov 13, 2026
Merged

raylau1 merged 1 commit into
lowRISC:mainfrom
raylau1:add-spec

Conversation

@raylau1

@raylau1 raylau1 commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@martin-velay martin-velay left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the DV side the per-register difference format works, the comments below are what a predictor still needs.

Outside this PR, in uart16550_translate.sv: the LSR read writes 1 to all four error bits of INTR_STATE after reading them, so an error that lands between the read and the clear is lost. Clearing only the bits read as 1 would avoid it.

Comment thread hw/ip/uart16550/doc/registers.md Resolved
Comment thread hw/ip/uart16550/doc/registers.md Resolved
Comment thread hw/ip/uart16550/README.md Resolved
Comment thread hw/ip/uart16550/doc/registers.md Resolved
Comment thread hw/ip/uart16550/doc/registers.md Resolved
Comment thread hw/ip/uart16550/doc/registers.md Resolved
Comment thread hw/ip/uart16550/doc/registers.md Resolved
Comment thread hw/ip/uart16550/doc/registers.md Resolved
@raylau1

raylau1 commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @martin-velay for raising the issue about clearing bits in INTR_STATE, I'll add this as a follow up RTL fix.

@raylau1
raylau1 force-pushed the add-spec branch 7 times, most recently from 1462f83 to d9b3b3d Compare November 12, 2026 09:47
Comment thread hw/ip/uart16550/README.md Resolved
@raylau1
raylau1 force-pushed the add-spec branch 2 times, most recently from a62c503 to 9b7fdc4 Compare November 12, 2026 10:53
Comment thread hw/ip/uart16550/doc/registers.md Resolved
Comment thread hw/ip/uart16550/doc/registers.md Resolved
Comment thread hw/ip/uart16550/doc/registers.md Resolved
Comment thread hw/ip/uart16550/README.md Resolved
Comment thread hw/ip/uart16550/doc/registers.md Resolved
Comment thread hw/ip/uart16550/doc/registers.md Resolved
Comment thread hw/ip/uart16550/doc/registers.md Resolved
@raylau1
raylau1 force-pushed the add-spec branch 4 times, most recently from db6bc32 to 5184a33 Compare November 12, 2026 15:38
Comment thread hw/ip/uart16550/doc/registers.md Resolved
@raylau1
raylau1 force-pushed the add-spec branch 2 times, most recently from 52022de to 62877a1 Compare November 12, 2026 16:09

@martin-velay martin-velay left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This spec LGTM now, thanks a lot Ray, I believe DV can work with it now

@marnovandermaas marnovandermaas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me. Just a few minor comments.

Comment thread hw/ip/REUSE.toml Resolved
Comment thread hw/ip/uart16550/doc/registers.md Resolved
Signed-off-by: Ray Lau <ray.lau@lowrisc.org>
@raylau1
raylau1 merged commit 4ab64e8 into lowRISC:main Nov 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[doc] Add documentation for features of the UART 16550 wrapper

3 participants