Repository navigation
[doc] Add wrapper feature documentation - #7
Merged
Merged
Conversation
martin-velay
left a comment
There was a problem hiding this comment.
From the DV side the per-register difference format works, the comments below are what a predictor still needs.
Outside this PR, in uart16550_translate.sv: the LSR read writes 1 to all four error bits of INTR_STATE after reading them, so an error that lands between the read and the clear is lost. Clearing only the bits read as 1 would avoid it.
Contributor
Author
|
Thanks @martin-velay for raising the issue about clearing bits in |
raylau1
force-pushed
the
add-spec
branch
7 times, most recently
from
November 12, 2026 09:47
1462f83 to
d9b3b3d
Compare
raylau1
force-pushed
the
add-spec
branch
2 times, most recently
from
November 12, 2026 10:53
a62c503 to
9b7fdc4
Compare
raylau1
force-pushed
the
add-spec
branch
4 times, most recently
from
November 12, 2026 15:38
db6bc32 to
5184a33
Compare
raylau1
force-pushed
the
add-spec
branch
2 times, most recently
from
November 12, 2026 16:09
52022de to
62877a1
Compare
martin-velay
approved these changes
Nov 12, 2026
martin-velay
left a comment
There was a problem hiding this comment.
This spec LGTM now, thanks a lot Ray, I believe DV can work with it now
marnovandermaas
approved these changes
Nov 13, 2026
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
I think this looks good to me. Just a few minor comments.
Signed-off-by: Ray Lau <ray.lau@lowrisc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes lowRISC/mocha#792.