Repository navigation
Sync with LovyanGFX: return from drawLine when its y range misses the clip rectangle - #383
Merged
Merged
Conversation
… clip rectangle From lovyan03/LovyanGFX#989. A line whose y range misses the clip rectangle returns before walking it pixel by pixel; it drew nothing before either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync
src/lgfx/with LovyanGFX develop.drawLine()returns before walking a line whose y range misses the clip rectangle. It drew nothing before either, so the drawn pixels are unchanged. On ESP32-S3, a 1280-pixel line below a 1280x7 sprite takes 0.4 µs instead of 82 µs; a visible line is unchanged.The synced file is identical to LovyanGFX develop.
Checks