Repository navigation
chore(deps): update dependency ubuntu to v26 - #147
mailersend-renovate[bot] wants to merge 1 commit into
Conversation
[Medium risk] The reported P2 about the stale 24.04 matrix value and job names is cosmetic and does not lower the score. The review did not check whether the ubuntu-26.04 runner label is available to this repository, nor whether the Java 11, 17 and 21 jobs pass on the new image; its account lists only the diff and a gh command, and the record shows no test run. The risk is medium because the change touches only CI and a revert restores the old runner at once. Findings
SummaryMoves the test job's runner from ubuntu-24.04 to ubuntu-26.04 Only Review context · 1/6 commands
Reviews (1) · Last reviewed commit: "chore(deps): update dependency ubuntu to..." · claude-sonnet-5-5 |
| run: | ||
|
|
||
| runs-on: ubuntu-24.04 | ||
| runs-on: ubuntu-26.04 |
There was a problem hiding this comment.
Job name still reports ubuntu-24.04 while running on 26.04 · correctness
After this change every job runs on ubuntu-26.04. The job name is Java X Test on ${{ matrix.operating-system }}, and the matrix still sets operating-system: [ubuntu-24.04]. Check names and any required status checks will therefore claim 24.04 while the job runs on 26.04. runs-on is also not driven by the matrix, so the matrix value is decoupled from the actual runner. Renovate only updated the one literal.
Suggested fix
Set runs-on: ${{ matrix.operating-system }} and change the matrix to operating-system: [ubuntu-26.04]. The job name and runner then stay in sync. If required status checks reference the old name, update them too.
Prompt for a coding agent
In .github/workflows/test.yml, change line 12 to `runs-on: ${{ matrix.operating-system }}` and change the matrix entry `operating-system: [ubuntu-24.04]` to `operating-system: [ubuntu-26.04]` so the job name matches the runner.
2a2104d to
832fad6
Compare
This PR contains the following updates:
24.04→26.04Configuration
📅 Schedule: (in timezone UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.