Repository navigation
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
ASM Prefixes are sometimes matched as exact string, sometimes as substring, which leads to prefixes such as `lock fs` to be missed, notably for PEB reads.
corkamig
force-pushed
the
fix/viv-segment-access
branch
from
November 3, 2026 11:20
8f1d4b5 to
833ca62
Compare
github-actions
Bot
dismissed
their stale review
November 3, 2026 11:20
CHANGELOG updated or no update needed, thanks! 😄
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the way prefixes are sometimes read as exact strings or as substrings, some PEB rules are missed when a segment prefix is combined with
lockorrep*.Fixed in
extract_insn_segment_access_featuresand added unit testtest_viv_segment_access_features.