Repository navigation
Hausdorff ctvs #2022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkerjean
wants to merge
18
commits into
math-comp:master
Choose a base branch
from
mkerjean:hausdorff_ctvs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hausdorff ctvs #2022
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5da4c39
adding seminorms to tvs
mkerjean 7bfe1ab
haussdorf ctvs
mkerjean 7c54483
fix rebase over seminorm
mkerjean d046b1d
rebase on seminorm_tvs
mkerjean ab02c7b
clean
mkerjean 15cb421
changelog and clean
mkerjean e3158d8
clean
mkerjean 616d62e
clean
mkerjean 029a6c3
Fail in line
mkerjean b0dcf4c
resolve line
mkerjean d119f1d
Apply suggestion from @affeldt-aist
affeldt-aist 58b811e
Apply suggestion from @affeldt-aist
affeldt-aist 477de39
Apply suggestion from @affeldt-aist
mkerjean 99f85ec
mention PR2166
mkerjean 4f63d2e
clean
mkerjean 9a5c52b
nitpick
affeldt-aist f88b706
linting
affeldt-aist 8a42c7b
linting
affeldt-aist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@affeldt-aist Do you have a suggestion as to where should these lemmas go ? Lemmas on
lmodtypeusing classical reasoningThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until now, we would have put such lemmas in
unstable.v(which is insideclassical). Butunstable.vis supposed to act as a purgatory for MathComp proper. In practice, it takes too long to emptyunstable.vand the lemmas you propose will never go to MathComp proper. So, isn't it time to create aclassical_algebra.vfile inclassical? @CohenCyril