Repository navigation
Allow the user to set a custom bluetooth name using the cli - #3754
Open
netrunnereve wants to merge 1 commit into
Open
netrunnereve wants to merge 1 commit into
netrunnereve wants to merge 1 commit into
Conversation
|
They should implement this and move the default Meshcore - into this method. I think that would solve everything. |
Author
From the way the backend code is written it looks like the Bluetooth name is intended to have a separate prefix (which can be changed at compile time) followed by the node name. I mean I could add another command to change the prefix as well but let's see what the maintainers think about this first. |
Cougar
reviewed
Nov 3, 2026
| sprintf(reply, "> %s", _prefs.ble_name[0] ? _prefs.ble_name : "(not set)"); | ||
| return true; | ||
| } | ||
| if (strcmp(command, "set ble_name_clear") == 0) { |
There was a problem hiding this comment.
Consider using set ble_name_default. The current wording is confusing because it does not 'clear' the BLE name; it resets it to the default value.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1243 by letting the user set their own bluetooth name using the cli. If there's no custom name set it'll automatically use the node name instead.
Note that this doesn't let them change the "Meshcore-" prefix as that apparently breaks some apps. If someone really wants to change that they'll have to build the firmware manually with a different
BLE_NAME_PREFIX.This acts as a workaround for #1769 as well since you now can just set a shorter name manually. I tested this on my Heltec v4 companion and it's working fine with a custom name set.