Repository navigation
[BREAKING] FEAT: Require a name when the API registers a target (part 16) - #4068
Open
varunj-msft wants to merge 260 commits into
Open
varunj-msft wants to merge 260 commits into
varunj-msft wants to merge 260 commits into
Conversation
…benchmark's recipes folder
… its Entra ID default
# Conflicts: # pyrit/prompt_target/azure_blob_storage_target.py
# Conflicts: # frontend/e2e/explicit-targets.seeded.spec.ts # frontend/src/components/Config/CreateTargetDialog.test.tsx # frontend/src/components/Config/CreateTargetDialog.tsx
The runtime status keeps its short summary. The restore log now also lists each field's full location and message, escaped, without the stored values, and with URL credentials removed. Credentials are removed before a location is shortened, so the summary can't keep part of one either.
# Conflicts: # pyrit/registry/registry_recipe_storage.py
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is one of the changes for saving Registry entries across restarts. Until the earlier PRs merge, the diff here also shows their changes.
POST /api/targetswithregisterleft on (the default) and nonameregistered the target under a generatedcompat_<hex>name. That fallback was marked LEGACY until targets required a name. Scorers already require one to register, and saved targets need one, so targets now match.name, or it gets a 422 ("name is required when register=true"). A request with"register": falsestill needs none.compat_<hex>fallback and its LEGACY notes are removed.What stays the same: a request with
"register": falsestill needs no name, and the GUI isn't affected because it always sends one.Breaking change: an API caller that relied on the generated name now gets a 422. To migrate, add
"name": "<registry name>"to the request. The GUI always sends a name, so it isn't affected.