Repository navigation
fix(fast-router): parse nested query parameters and arrays - #7779
Open
vansh (vansh-nagar) wants to merge 1 commit into
Open
vansh (vansh-nagar) wants to merge 1 commit into
vansh (vansh-nagar) wants to merge 1 commit into
Conversation
vansh (vansh-nagar)
requested review from
Chris Holt (chrisdholt),
Jane Chu (janechu) and
John Kreitlow (radium-v)
as code owners
October 25, 2026 02:55
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
vansh (@vansh-nagar) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Parsing a URL such as
/search?filter[category]=hardwarethrowsTypeError: currentParams.get is not a function, interrupting route recognition. Use object/array indexing for nested parameters so bracketed objects, indexed arrays, and append-style arrays parse successfully, including output fromQueryString.build().Traversal uses own properties and ignores
__proto__paths so restoring nested parsing does not follow inherited containers. The router's Node test command now includes the new query-string suite.🎫 Issues
Fixes #7741
👩💻 Reviewer Notes
Implementation and tests were developed with Codex. This preserves the existing public TypeScript signatures. The string-only typing of structured query values is outside this fix.
📑 Test Plan
currentParams.get is not a function; the flat-query control passes.npm run test -w @microsoft/fast-router: 10,930 tests pass; lint and API report checks pass.npm test: all 13 runnable monorepo tasks pass (one task skipped); source and declarative browser suites complete without failures across Chromium, Firefox, and WebKit.npm run test:validationandnpm run biome:cipass.npm run build: all nine monorepo builds pass (macOS arm64, Node 26.0.0).npm run format:check, andnpm run checkchangepass.✅ Checklist
General
$ npm run changeAgents
The router package has no DESIGN.md.