Skip to content

FOCUS query library - #1401

Draft
Michael Flanakin (flanakin) wants to merge 5 commits into
devfrom
flanakin/dev/focus-queries
Draft

Michael Flanakin (flanakin) wants to merge 5 commits into
devfrom
flanakin/dev/focus-queries

Conversation

@flanakin

Copy link
Copy Markdown
Collaborator

🛠️ Description

Initial thoughts about a FOCUS query library.

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin Michael Flanakin (flanakin) added Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity Tool: FinOps guide Implementing FinOps guide Tool: FOCUS FOCUS feedback and documentation labels Mar 14, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Review 👀 PR that is ready to be reviewed label Mar 14, 2025
@flanakin Michael Flanakin (flanakin) removed the Needs: Review 👀 PR that is ready to be reviewed label Mar 14, 2025
SubAccountId
```

**SQL**

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we avoid overlaps with the FinOps Foundation's Use Case Library? Will that library be populated with Frequently Asked Queries?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [AI] ❓ Question

Overlap with the FinOps Foundation Use Case Library is a scope call for the PR author; flagged for decision.

Co-Authored-By: RolandKrummenacher <RolandKrummenacher@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs: Review 👀 PR that is ready to be reviewed and removed Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity labels Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The KQL change in 6760d14 is fine. The SQL example doesn't run, and both queries mix currencies.

On the Use Case Library thread: your AI flagged it for your decision, so it stays with you.

Comment thread docs-mslearn/focus/queries.md Resolved
Comment thread docs-mslearn/focus/queries.md Resolved
Comment thread docs-mslearn/focus/queries.md Resolved
@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity and removed Needs: Review 👀 PR that is ready to be reviewed labels Oct 30, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown

@Michael Flanakin (@flanakin): you have some new feedback!

Please review and resolve all comments and I'll let reviewers know by removing the Needs: Attention label. If I miss anything, just reply with #needs-review and I'll update the status.

Co-Authored-By: RolandKrummenacher <RolandKrummenacher@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs: Review 👀 PR that is ready to be reviewed and removed Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity labels Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, d82b194 fixes all three points: the SQL now groups by every selected column, the cost column has an alias, and both queries split by BillingCurrency. The queries are consistent with each other and the SQL is valid T-SQL. Lifting my change request.

The Use Case Library overlap question is still open with you. It's your call and doesn't block this PR.

Non-blocking: focus/queries.md isn't in docs-mslearn/TOC.yml yet, so the page won't show up in the Learn navigation. Add it under the FOCUS section unless it's meant to stay unlisted for now.

Comment thread docs-mslearn/focus/queries.md Resolved
Comment thread docs-mslearn/focus/queries.md Resolved
Comment thread docs-mslearn/focus/queries.md Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps guide Implementing FinOps guide Tool: FOCUS FOCUS feedback and documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants