Repository navigation
FOCUS query library - #1401
FOCUS query library#1401Michael Flanakin (flanakin) wants to merge 5 commits into
Conversation
| SubAccountId | ||
| ``` | ||
|
|
||
| **SQL** |
There was a problem hiding this comment.
Shall we avoid overlaps with the FinOps Foundation's Use Case Library? Will that library be populated with Frequently Asked Queries?
There was a problem hiding this comment.
🤖 [AI] ❓ Question
Overlap with the FinOps Foundation Use Case Library is a scope call for the PR author; flagged for decision.
Co-Authored-By: RolandKrummenacher <RolandKrummenacher@users.noreply.github.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Roland Krummenacher (RolandKrummenacher)
left a comment
There was a problem hiding this comment.
The KQL change in 6760d14 is fine. The SQL example doesn't run, and both queries mix currencies.
On the Use Case Library thread: your AI flagged it for your decision, so it stays with you.
|
@Michael Flanakin (@flanakin): you have some new feedback! Please review and resolve all comments and I'll let reviewers know by removing the |
Co-Authored-By: RolandKrummenacher <RolandKrummenacher@users.noreply.github.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Roland Krummenacher (RolandKrummenacher)
left a comment
There was a problem hiding this comment.
Thanks, d82b194 fixes all three points: the SQL now groups by every selected column, the cost column has an alias, and both queries split by BillingCurrency. The queries are consistent with each other and the SQL is valid T-SQL. Lifting my change request.
The Use Case Library overlap question is still open with you. It's your call and doesn't block this PR.
Non-blocking: focus/queries.md isn't in docs-mslearn/TOC.yml yet, so the page won't show up in the Learn navigation. Add it under the FOCUS section unless it's meant to stay unlisted for now.
🛠️ Description
Initial thoughts about a FOCUS query library.
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?