Repository navigation
[Demo] Export the billing account and keep 36 months for the latest version - #2403
Merged
Michael Flanakin (flanakin) merged 3 commits intoNov 1, 2026
Merged
Conversation
… latest version - Default the current demo hub and the version being built to the demo EA billing account instead of the subscription, which is inside it and would duplicate costs. - Grant the hub's identity the Enterprise Administrator (read only) billing role on EA billing accounts. Only subscriptions and management groups were handled, so billing account exports never started for new hubs. - Remove exports on scopes that are no longer exported. - Keep 36 months for the version being built, not just the unversioned demo hub. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Michael Flanakin (flanakin)
requested a review
from Brett Wilson (MSBrett)
as a code owner
October 30, 2026 10:57
microsoft-github-policy-service
Bot
added
Skill: DevOps
Roland Krummenacher (RolandKrummenacher)
left a comment
Roland Krummenacher (RolandKrummenacher)
left a comment
Collaborator
There was a problem hiding this comment.
The approach is right. Per the description, it hasn't run end to end yet. Two points before the real run on ftk-demo, plus one on the data it already has.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Check status codes when listing and deleting stale exports - Only treat a missing settings.json as no scopes - Document removing data left by the old scope 🤖 Generated with [Claude Code](https://claude.ai/claude-code) Co-Authored-By: RolandKrummenacher <RolandKrummenacher@users.noreply.github.com> Co-Authored-By: Claude <noreply@anthropic.com>
Roland Krummenacher (RolandKrummenacher)
approved these changes
Nov 1, 2026
Roland Krummenacher (RolandKrummenacher)
left a comment
Roland Krummenacher (RolandKrummenacher)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, all three points are addressed. I checked them in the code: the stale-export cleanup now checks status codes on both the list and the delete, Get-DemoScope only treats a missing settings.json as no scopes and lets everything else retry, and the README covers clearing the old scope's data.
The new viewer step looks right. aaduser=#everyone# and msauser=#everyone# are the documented "everyone" principals, and with trustedExternalTenants unset the cluster accepts all tenants. Two non-blocking points:
- The PR description doesn't mention that the demo hub databases are now readable by anyone. Please add it, since it changes who can access the data.
- It still hasn't run end to end. Worth checking
.show database Hub principalsafter the real run onftk-demo-v15.
Michael Flanakin (flanakin)
deleted the
flanakin/demo-hub-billing-account
branch
November 1, 2026 20:50
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the v15 demo hub (
ftk-demo-v15) only having October data. It exported the FTK Prod subscription instead of the demo billing account, which had almost no cost before October.ftk-demo.Not run end to end yet. A dry run with
-WhatIfpasses. The real run onftk-demo-v15is pending.🤖 Generated with Claude Code