Skip to content

fix(pptx): preserve date-axis category labels - #2734

Open
他们都不玩了 (shuaiyafei) wants to merge 2 commits into
microsoft:mainfrom
shuaiyafei:fix/pptx-date-categories
Open

他们都不玩了 (shuaiyafei) wants to merge 2 commits into
microsoft:mainfrom
shuaiyafei:fix/pptx-date-categories

Conversation

@shuaiyafei

@shuaiyafei 他们都不玩了 (shuaiyafei) commented Oct 22, 2026 •

Copy link
Copy Markdown

Problem

A PowerPoint chart with a date axis exports its Excel serial numbers as category labels. For example, a monthly revenue chart with dates 2026-01-01 and 2026-02-01 currently produces 46023.0 and 46054.0. The Markdown loses the dates needed to interpret the time series.

This was found through source analysis and reproduced with serialized PPTX files through the public Python API and CLI.

Change

Format date-axis categories as ISO dates, using the chart's declared 1900 or 1904 date system. Match the first plot's axis IDs before interpreting its categories as dates, so a date axis on a different plot cannot change numeric labels. Fractional days retain their time component. Ordinary numeric categories keep their values. Unparseable labels and Excel's fictitious February 29, 1900 retain their original text.

Reproduction

from datetime import date
from io import BytesIO
from pptx import Presentation
from pptx.chart.data import CategoryChartData
from pptx.enum.chart import XL_CHART_TYPE
from pptx.util import Inches
from markitdown import MarkItDown

deck = Presentation()
slide = deck.slides.add_slide(deck.slide_layouts[6])
data = CategoryChartData()
data.categories = [date(2026, 1, 1), date(2026, 2, 1)]
data.add_series("Revenue", [100, 120])
slide.shapes.add_chart(XL_CHART_TYPE.LINE, 0, 0, Inches(6), Inches(4), data)
stream = BytesIO()
deck.save(stream)
stream.seek(0)
print(MarkItDown().convert_stream(stream, file_extension=".pptx").markdown)

Before: | 46023.0 | 100.0 |. After: | 2026-01-01 | 100.0 |.

Verification

  • The same public conversion tests on unchanged 21d9c1d give 2 failures for the date systems and 2 passing controls for numeric labels.
  • python -m pytest packages/markitdown/tests/test_pptx.py -q: 61 passed.
  • Mixed-axis coverage reproduces the incorrect numeric-label conversion on the previous PR head. The reverse layout, with dates on the first plot, is a passing control. Both layouts use independent axes and a matching embedded workbook.
  • The 1904 fixture updates both chart caches and the embedded workbook's date system. Both serialized date fixtures also pass python -m markitdown <file.pptx>.
  • pre-commit run --all-files and git diff --check: passed.

Tested on macOS arm64 with Python 3.12.15 and python-pptx 1.0.2. The complete all-format suite and live OCR/LLM integrations were not run. Date-formatted numeric caches on Text axes are not covered by this change; PowerPoint UI behavior was not verified.

AI assistance: Codex helped investigate, implement, and validate this change.

@gdols Guillermo Dols (gdols) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran tests/test_pptx.py here (59 passed) and pushed a few more values through _format_date_category: float noise in the time part comes out clean (45658.333333333336 gives 2025-01-01T08:00:00), the last Excel date 2958465 gives 9999-12-31, and anything past it, nan or inf keeps the original label.

One case it misses is a date axis switched to Text axis. To try it I took your 1900 fixture and renamed c:dateAx to c:catAx, dropping the time unit children. The categories are still a numRef with the yyyy\-mm\-dd format code, so a text axis should still show them as dates, but the output goes back to | 46023.0 | 100.0 |. I don't have PowerPoint here to confirm exactly what it writes when you change the axis type, so take that part with a grain of salt.

Checking the category formatCode instead of the axis element would cover both, and it would tie the check to the categories of plots[0], which are the ones being printed. As it is, a combo chart with a date axis on another plot would convert the first plot's labels too. Just a thought, I'd be fine with it going in as it is.

@microsoft-github-policy-service

Copy link
Copy Markdown

他们都不玩了 (@shuaiyafei) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants