Skip to content

[eMudra] Require Go 1.26.10 for moc builds - #454

Merged
Madhan Raj Mookkandy (madhanrm) merged 1 commit into
mainfrom
madhanm/emudhra-remaining-moc-20261023
Oct 23, 2026
Merged

Madhan Raj Mookkandy (madhanrm) merged 1 commit into
mainfrom
madhanm/emudhra-remaining-moc-20261023

Conversation

@madhanrm

Copy link
Copy Markdown
Collaborator

Summary

Require the approved Go 1.26.10 compiler floor for eMudra remediation.

Independent protobuf/build/unit/lint source jobs still select minor-only compiler; central library compilation cannot close local source-floor gap. No proto/API/tag cascade needed for standard-library compiler remediation.

Changes

  • go.mod:3 1.26 -> 1.26.10; .pipelines/build.yaml:21,:81 both 1.26 -> 1.26.10.
  • Preserve Makefile compiler overrides/exports, endpoints, library APIs, dependency versions and checksums. No dependency-tag cascade or product logic changes.

Validation

  • Exact Go1.26.10 linux/amd64 with GOTOOLCHAIN=local: go mod tidy -diff, full go build -p=4 ./..., and documented make unittest PASS. Protobuf regeneration and lint/security CI remain pending; generated APIs were intentionally not changed.
  • Exact Go1.26.9 windows/amd64 with GOTOOLCHAIN=local: go list -m rejects the new floor (expected).
  • Parsed pipeline YAML; every existing GoTool selector is exactly 1.26.10. Version-only diff, LF endings preserved; git diff --check PASS.
  • Required CI/lint/security checks pending. Draft is required by live repository instructions until checks pass; no full-CI green claim.
  • Source floors do not prove signed supported-package replacement, native Windows trust, ARM execution or installed-population closure.

Engineering Checklist

Item Evidence / remaining gate
Scope Module compiler minimum and existing installer selectors only
Tests Local results and exact limitations above; required remote CI pending
Compatibility No API/dependency/tag changes; consumers still need rebuild qualification
Release No Official/release/fleet operations or merge/autocomplete

Related Work Items

AB#40301108 (CloudNativeCompute)

Copilot Context

  • Skills used: pr-creation (isolated worktree and provenance), pr-greening (MOC GitHub CI workflow), moc-developer (actual build/test/mock targets).
  • Prompt: Continue authorized eMudhra/eMudra remediation in only the seven undelivered MOC GitHub repos; implement justified compiler-source fixes, validate Go 1.26.10, and raise actual same-repository PRs without duplicating other workers.

Copilot-Session: 475922ed-15c9-4f44-94d1-e6a02f851473
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

AB#40301108 (CloudNativeCompute)

Copilot-Session: 475922ed-15c9-4f44-94d1-e6a02f851473
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@madhanrm

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@madhanrm

Copy link
Copy Markdown
Collaborator Author

Readiness reconciliation for the current source commit: GitHub reports the Azure root as successful, but the underlying Azure build is actually partiallySucceeded, so this PR remains Draft. Run CodeQL (Semmle) cannot upload its snapshot because System_AccessToken is missing/empty.

The static-analysis YAML is byte-identical to the authoritative default branch; this PR only changes the documented compiler floor/installers. Baseline build: The exact current default-branch SHA also reports the same missing-token failure.

No introduced compiler-source defect was found in these errors. No retry was queued for these deterministic configuration failures, and no token, permissions, continuation behavior, or security policy was changed. Ready conversion is withheld until the actual required Azure build succeeds. Native/shipping qualification limits in the PR description remain unchanged.

@madhanrm
Madhan Raj Mookkandy (madhanrm) marked this pull request as ready for review October 23, 2026 16:53
@madhanrm

Copy link
Copy Markdown
Collaborator Author

[Copilot] Installed-runtime token handoff (no scanner migration)

Ready is retained by explicit user instruction; this is not a fully-green claim. Actual failing uploader log remains authoritative rather than the successful GitHub wrapper.

Read-only inspection of the exact installed Guardian 0.293.26286.2 runtime and Semmle 1.302.1 establishes the token handoff contract:

  • Existing static YAML already maps SYSTEM_ACCESSTOKEN; task-lib/launcher inherit that environment.
  • Guardian BaseStartup.Run caches/clears the reserved token before HandledRun on its standard authentication path.
  • CliAnalyzer.Analyze reinjects it into the analyzer only when ToolConfig.RequiresSystemAccessToken is true.
  • Both installed Windows Semmle tool descriptors omit that requirement. The legacy uploader then requires System_AccessToken (QLTaskHelpers.psm1:594-597).

The narrowly indicated domain correction is the existing tool-token requirement contract, owned by the SecDevTools/Guardian runtime publisher (securedevelopmentteam.vss-secure-development-tools, support documentation). A supported repository-local override or editable central publishing surface has not been established; no guessed variable/file, agent-cache patch, new grant, user credential, fork-policy change or bypass was applied. Actual reinjection/upload still needs verification after a supported owner-delivered correction.

The earlier unconditional local CodeQL3000 migration candidate was rejected and was not applied: local analysis cannot replace CAP compliance upload or the required findings gate. Existing security signals, severities, reporting identities and compiler floors are unchanged.

@madhanrm
Madhan Raj Mookkandy (madhanrm) merged commit d5a095c into main Oct 23, 2026
7 checks passed
Madhan Raj Mookkandy (madhanrm) added a commit that referenced this pull request Oct 28, 2026
…20261023 (#457)

## Summary

Cherry-pick the merged eMudra compiler fix to `releases/v0.42.0` for subsequent MOC patch-release preparation (ASZ `June2026-ASZ`). PR preparation only; this does not authorize or start a release.

## Changes

- Require Go `1.26.10` in the module minimum and independently referenced local GoTool pipeline selectors.
- Preserve the existing Go 1.26 release minor and all release-line dependency/replacement pins. No `go.sum`, product logic, tags, catalog, or security-policy changes.

## Cherry-pick provenance

- Source PR: #454
- Source merge: `d5a095c69ae07a652681abeebe1bfdce14353bf8`
- Verified release baseline: `f8d7e19a10192da9854f326351b4be83741befe6`
- CP commit: `fc54a166a4bcd4ecd6a5ef07896a65fea1835fb9`
- Applied cleanly using `git cherry-pick -x` with `-m 1` for the source merge commit.

## Testing

- PASS: `git diff --check`; changed YAML parses.
- PASS: every tracked local GoTool selector is exactly `1.26.10`; `go.mod` parses with minimum `1.26.10`; all non-directive module content and `go.sum` are unchanged.
- PASS: effective local compiler is `go1.26.10 windows/amd64`, with `GOTOOLCHAIN=local`.
- PASS: `go test -count=1 ./pkg/config` with Go 1.26.10 (Windows, CGO disabled, offline, readonly modules).
- Full cross-platform binary builds, lint/static analysis, and CI remain pending. GNU make and MinGW/GCC are unavailable locally. Draft pending required validation; no claim of full green.

## Checklist

- [ ] Required build, test, lint, and security checks pass
- [ ] Human review completed
- [ ] Separate MOC hotfix-release authorization obtained after CP merge

## Related Work Items

Source work: [AB#40301108](https://dev.azure.com/msazure/msk8s/_workitems/edit/40301108).

## Copilot Context

- Skills: `moc-patch-release` (release-branch provenance), `pr-creation` (isolated worktree and PR preparation).
- Prompt: "CP eMudra MOC fixes to this release branches and give me the table with links"; "we have to make moc hotfix release after that".
- Bounded preparation only: no explicit pipeline triggers, merge/vote/autocomplete, SFS, wiki, or catalog changes.
- Copilot-Session: 851d17a8-4268-4464-8220-1d1fe8bafc20

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants