Skip to content

cherry-pick(#43478): chore: roll driver/Dockerfile to recent Node.js LTS version - #43829

Open
Dmitry Gozman (dgozman) wants to merge 1 commit into
microsoft:release-1.64from
dgozman:r1.64-38fb53b
Open

Dmitry Gozman (dgozman) wants to merge 1 commit into
microsoft:release-1.64from
dgozman:r1.64-38fb53b

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

No description provided.

… Node.js LTS version

Co-authored-by: microsoft-playwright-automation[bot] <203992400+microsoft-playwright-automation[bot]@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

4 failed
❌ [chromium-page] › page/page-network-sizes.spec.ts:78 › should have the correct responseBodySize for chunked request @chromium-ubuntu-22.04-node24
❌ [default] › problems.spec.ts:19 › should list tests on expand @vscode-extension
❌ [default-reuse] › problems.spec.ts:19 › should list tests on expand @vscode-extension
❌ [default-trace] › problems.spec.ts:19 › should list tests on expand @vscode-extension

8 flaky ⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/webmcp.spec.ts:238 › should call same-name tools in their own frame `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/webmcp.spec.ts:256 › should list and call tools in cross-origin and nested frames `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:80 › should connect when the opener of an existing page has no renderer `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

52883 passed, 1270 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 The reported failures are not caused by this PR

Hi, I'm the Playwright bot. I checked the four failures in the latest merged report.

Details

At 34591c8, this PR only changes NODE_VERSION from 24 to 26 in three Dockerfiles. Neither failing job uses those images: Chromium runs on host Node.js 24, and VS Code on host Node.js 20. All six Docker test jobs passed.

Pre-existing test / environment failures

  • Chunked response size: [chromium-page] › page/page-network-sizes.spec.ts:78 › should have the correct responseBodySize for chunked request expects 5175 bytes but receives 5113 on all four attempts. After refreshing the test-results database, I found the identical failure on cherry-pick(#43679): fix(docker): use latest stable Chrome for Testing #43828, SHA a70bb23, in the same Node.js 24 job, and on main, SHA 41fad5e, on October 15. This is an existing failure, not evidence against this Docker-only change.

  • VS Code diagnostic range: problems.spec.ts:19 › should list tests on expand fails in default, default-reuse, and default-trace: the diagnostic starts at character 7, but the test expects 8. All three already failed with the same mismatch on this PR's base commit, 0915b2e, in the October 15 baseline job. They also fail identically on #43828. The database has no entries for this extension test; these comparisons use the job logs directly.

These are confirmed pre-existing failures, not failures classified as flakes from their symptoms. The MCP Windows/Firefox job was still running when checked; this verdict covers the reported failures.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

9048 passed, 1495 skipped


Merge workflow run.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants