Repository navigation
Add CGC lowering target options to compile, eval, and perf - #1490
Merged
Zhenchao Ni (zhenchaoni) merged 3 commits intoOct 23, 2026
Merged
Conversation
Qiong Wu (qiowu) (DingmaomaoBJTU)
requested changes
Oct 23, 2026
Qiong Wu (qiowu) (DingmaomaoBJTU)
left a comment
Collaborator
There was a problem hiding this comment.
One input-validation issue remains before approval. All 538 existing affected tests passed locally; Ruff and git diff --check passed. A focused additional CLI probe reproduced acceptance of --runtime winml-ort --cgc-lowering-target d3d12 (exit 0 and benchmark config retained d3d12), although the non-Runtime model path discards that setting. Native behavior for recompiling existing Output IR was not exercised locally.
Zhenchao Ni (zhenchaoni)
force-pushed
the
private/zhenni/cgc_lowering_target
branch
from
October 23, 2026 07:46
6f62530 to
5bdb7a7
Compare
Qiong Wu (qiowu) (DingmaomaoBJTU)
approved these changes
Oct 23, 2026
Zhenchao Ni (zhenchaoni)
deleted the
private/zhenni/cgc_lowering_target
branch
October 23, 2026 08:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
--cgc-lowering-target auto|dml|d3d12option tocompile,eval, andperf, allowing users to select the CGC lowering target.Examples
Benchmark an ONNX model using CGC with DirectML lowering:
Compile CGC Input IR with D3D12 lowering: