Skip to content

docs: fix tRPC/Hono comparison claims and old URL redirects - #2322

Merged
dinwwwh merged 4 commits into
mainfrom
claude/project-thread-92i5up
Oct 24, 2026
Merged

dinwwwh merged 4 commits into
mainfrom
claude/project-thread-92i5up

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Requested by dinwwwh · project thread

  • Comparison: tRPC Retry 🛑 → 🟡 (retryLink ships in @trpc/client 11.19). Hono contract-first and OpenAPI ✅ → 🟡 (third-party middleware per hono.dev), also on the home page. Mention @trpc/openapi (alpha) and date the error-shape claim.
  • tRPC migration guide: serializer row is transformer, not superjson; fix two mangled route file titles.
  • Redirects: two old v1 URLs that moved to the same feature (zod-smart-coercion, tanstack-query-old/*).
  • /logo.webp: restored; npm READMEs embed it.

pnpm docs:validate passes; the production build and blume audit showed 0 errors.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WwvdJXUJLcD4apwHfgDgkV

…on guide

- tRPC ships retryLink in @trpc/client 11.19, so "Built-in plugins
  (CORS, CSRF, Retry)" is partial, not unsupported.
- Hono's OpenAPI and contract-first support come from middleware that
  hono.dev lists as third-party, the same source as its Standard Schema
  validator the page already rates partial. Mark both partial on the
  comparison page and the home page summary.
- Name tRPC's official @trpc/openapi (alpha) in the OpenAPI prose, date
  the "one global error shape" claim, and stamp the versions checked.
- Migration guide: tRPC's serializer is a configurable transformer
  (JSON by default), and fix two mangled Next.js route file titles.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WwvdJXUJLcD4apwHfgDgkV
…osts OG images

- 23 URLs that orpc.dev served in v1 return 404 today. Point the 17 with
  a v2 counterpart at it (mappings follow the v1 migration guide) and the
  v1-only pages (custom plugins, body parser, OpenAI streaming, Sentry,
  learn-and-contribute) at v1.orpc.dev, where they still live.
- Restore /logo.webp and /og.jpg from the 1.x branch. The README on every
  npm `latest` (1.16.x) page embeds the logo, and the v1 site's og:image
  and twitter:image point at og.jpg, so both are broken today.
- Blog posts render through a dynamic route, where PageLayout attaches no
  generated OG card, so shares had no image and the small Twitter card.
  Point them at the card Blume already renders for each post.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WwvdJXUJLcD4apwHfgDgkV
@dinwwwh dinwwwh self-assigned this Oct 24, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Approvability

Verdict: Approved at 0cce3d1

Macroscope's review found this PR approvable — This is a low-risk content maintenance change: documentation claims and examples are corrected, homepage comparison labels are synchronized, two legacy documentation URLs redirect to current pages, and a static logo asset is restored. No application logic, API schema, security-sensitive code, or production infrastructure is changed.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 24, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
orpc 0cce3d1 Commit Preview URL

Branch Preview URL
Oct 24 2026, 04:03 AM

@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pkg-pr-new

pkg-pr-new Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
More templates

@orpc/ai-sdk

npm i https://pkg.pr.new/@orpc/ai-sdk@2322

@orpc/arktype

npm i https://pkg.pr.new/@orpc/arktype@2322

@orpc/bun

npm i https://pkg.pr.new/@orpc/bun@2322

@orpc/client

npm i https://pkg.pr.new/@orpc/client@2322

@orpc/cloudflare

npm i https://pkg.pr.new/@orpc/cloudflare@2322

@orpc/contract

npm i https://pkg.pr.new/@orpc/contract@2322

@orpc/experimental-effect

npm i https://pkg.pr.new/@orpc/experimental-effect@2322

@orpc/evlog

npm i https://pkg.pr.new/@orpc/evlog@2322

@orpc/hibernation

npm i https://pkg.pr.new/@orpc/hibernation@2322

@orpc/json-schema

npm i https://pkg.pr.new/@orpc/json-schema@2322

@orpc/experimental-lock

npm i https://pkg.pr.new/@orpc/experimental-lock@2322

@orpc/mcp

npm i https://pkg.pr.new/@orpc/mcp@2322

@orpc/msw

npm i https://pkg.pr.new/@orpc/msw@2322

@orpc/nest

npm i https://pkg.pr.new/@orpc/nest@2322

@orpc/next

npm i https://pkg.pr.new/@orpc/next@2322

@orpc/node

npm i https://pkg.pr.new/@orpc/node@2322

@orpc/openapi

npm i https://pkg.pr.new/@orpc/openapi@2322

@orpc/opentelemetry

npm i https://pkg.pr.new/@orpc/opentelemetry@2322

@orpc/pinia-colada

npm i https://pkg.pr.new/@orpc/pinia-colada@2322

@orpc/pino

npm i https://pkg.pr.new/@orpc/pino@2322

@orpc/publisher

npm i https://pkg.pr.new/@orpc/publisher@2322

@orpc/ratelimit

npm i https://pkg.pr.new/@orpc/ratelimit@2322

@orpc/server

npm i https://pkg.pr.new/@orpc/server@2322

@orpc/shared

npm i https://pkg.pr.new/@orpc/shared@2322

@orpc/swr

npm i https://pkg.pr.new/@orpc/swr@2322

@orpc/tanstack-query

npm i https://pkg.pr.new/@orpc/tanstack-query@2322

@orpc/trpc

npm i https://pkg.pr.new/@orpc/trpc@2322

@orpc/valibot

npm i https://pkg.pr.new/@orpc/valibot@2322

@orpc/zod

npm i https://pkg.pr.new/@orpc/zod@2322

commit: 0cce3d1

@codspeed

codspeed Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

1 warning

⚠️ 5 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 28 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing claude/project-thread-92i5up (0cce3d1) with main (23fc494)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — reviewed the complete diff (7 files, 2 commits), checked against the repo, Blume internals, npm, and the 1.x branch.

  • Comparison claims — docs/comparison.mdx and pages/_home/Comparison.astro: tRPC built-in plugins 🛑→🟡 (retryLink), Hono contract-first and OpenAPI ✅→🟡, the tRPC error-shape claim dated to 11.19, and the OpenAPI prose rewritten around @trpc/openapi / @hono/zod-openapi, plus a "last checked" line. Both pages stay consistent.
  • tRPC migration guide — serializer row corrected to transformer (e.g. superjson), and the two mangled Next.js route-file fence labels fixed to title="...".
  • v1 redirects — 14 new rules in blume.config.ts; every v2 target resolves to an existing page (and both # anchors hit real headings), and every v1 from path exists on 1.x.
  • Restored assets — public/logo.webp and public/og.jpg (1200×630), which fixes the v1 npm README logo and the v1 site's OG image served from orpc.dev.
  • Blog OG cards — pages/blog/[...slug].astro now passes ogImage/ogImageAlt/ogImageSize; /og/<path>.png matches Blume's generated-card route, and the props match PageLayout's contract.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

Drop redirects to v1.orpc.dev and to different features, so those URLs
stay free for future pages. Keep the current OG image setup, and tighten
the new comparison wording.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WwvdJXUJLcD4apwHfgDgkV
@dinwwwh dinwwwh changed the title docs: correct tRPC/Hono comparison claims and fix dead v1 links and blog share images docs: fix tRPC/Hono comparison claims, old URL redirects, and blog OG images Oct 24, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review October 24, 2026 02:49

Dismissing prior approval to re-evaluate 8ccf2cd

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 24, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one observation in the body.

Reviewed changes — delta from the prior pullfrog review (a1c4ab06 → 8ccf2cd): the redirect list was narrowed, the comparison prose tightened, the blog OG comment shortened, and og.jpg dropped.

  • Redirects narrowed — blume.config.ts now keeps only the two same-feature moves (/docs/openapi/plugins/zod-smart-coercion → /docs/plugins/smart-coercion, /docs/integrations/tanstack-query-old/:slug* → /docs/integrations/tanstack-query); ten rules added by the previous commit (adapter aliases, superjson/strict-get-method, the v1.orpc.dev fallbacks, durable-iterator) were dropped, returning those URLs to their pre-PR 404 state. Both retained sources exist on 1.x, both targets exist on main, and Blume 2.2.3 supports the :slug* pattern.
  • Comparison copy — docs/comparison.mdx: OpenAPI paragraph rewritten around @trpc/openapi (alpha, tRPC-style endpoints) and @hono/zod-openapi; error-shape claim dated (as of 11.19); legend line shortened to Checked against tRPC 11.19 and Hono 4.13 (October 2026).
  • Blog OG comment — pages/blog/[...slug].astro: the comment above ogImage was condensed; the ogImage/ogImageAlt/ogImageSize props are unchanged.
  • Assets — public/logo.webp kept (v1 READMEs embed it); public/og.jpg removed.

ℹ️ Dropping og.jpg leaves the v1 docs' social image 404ing

The v1 docs still point their Open Graph and Twitter image metadata at https://orpc.dev/og.jpg, which is the v2 site's public/ directory. That URL currently returns 404, and 8ccf2cd removes the public/og.jpg that the preceding commit added to fix exactly this — so v1 doc link previews stay broken after this PR.

Technical details
# Restore `og.jpg` (or repoint the v1 config)

## Affected sites
- `apps/content/.vitepress/config.ts` (branch `1.x`) — `['meta', { property: 'og:image', content: 'https://orpc.dev/og.jpg' }]` and the matching `twitter:image` entry; both are absolute and resolve against the v2 domain this PR edits.
- `apps/content/public/og.jpg` — removed by `8ccf2cd`; absent from base `main`.
- `apps/content/blume.config.ts` — no `og.jpg` reference; the only `/og` output is Blume's per-route `/og/<route>.png` cards, so nothing serves `/og.jpg`.

## Required outcome
- `https://orpc.dev/og.jpg` resolves again, or the v1 metadata is changed to a URL that does (e.g. the v1 site's own domain or a generated card).

## Suggested approach (optional)
- Restore the 1200×630 `public/og.jpg` alongside `public/logo.webp`, matching the explicit reason `logo.webp` was kept (v1 `READMEs`/config embed assets on the `orpc.dev` origin). If the v1 config is changing instead, do it here so the two don't drift.

## Open questions for the human (optional)
- Was dropping `og.jpg` intentional because the v1 OG image is being retired/repointed elsewhere? If so, the v1 `.vitepress/config.ts` still needs the update.

Pullfrog  | Fix it ➔ | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WwvdJXUJLcD4apwHfgDgkV
@dinwwwh dinwwwh changed the title docs: fix tRPC/Hono comparison claims, old URL redirects, and blog OG images docs: fix tRPC/Hono comparison claims and old URL redirects Oct 24, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review October 24, 2026 04:01

Dismissing prior approval to re-evaluate 0cce3d1

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — delta from the prior pullfrog review (8ccf2cd → 0cce3d1b): a single commit that reverts the blog post OG image props.

  • Blog route reverted — pages/blog/[...slug].astro drops the explicit ogImage/ogImageAlt/ogImageSize props, returning the dynamic route to its base state, so the PR no longer modifies the blog page at all.
  • Scope narrowed to match — the PR title and body were updated to drop the blog OG item, consistent with the revert.

Git confirms the delta is exactly 7 deletions in that one file; nothing else changed since the prior review.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@dinwwwh
dinwwwh merged commit 72d7857 into main Oct 24, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants