Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the removal of obsolete V1 workflow execution support.
No open issues 🎉
What changed in this PR
Removes obsolete V1 workflow execution support from the .NET SDK to match its removal from the server. This is a breaking change for consumers of the removed APIs.
Changes:
- Removes client workflow execution methods and their HTTP implementation.
- Deletes workflow request and response types.
- Removes related tests and the execution code sample while retaining workflow prediction tests.
| File | Description |
|---|---|
tests/Mindee.UnitTests/V1/Workflow/WorklowTest.cs |
Deletes tests for the removed execution APIs. |
tests/Mindee.IntegrationTests/V1/Workflow/WorkflowTest.cs |
Removes the workflow upload test. |
src/Mindee/V1/Parsing/Common/WorkflowResponse.cs |
Deletes the workflow response type. |
src/Mindee/V1/Http/WorkflowParameter.cs |
Deletes workflow request parameters. |
src/Mindee/V1/Http/MindeeApi.cs |
Removes the execution endpoint call and request builder. |
src/Mindee/V1/Http/IHttpApi.cs |
Removes the workflow execution interface method. |
src/Mindee/V1/Client.cs |
Removes local and remote ExecuteWorkflowAsync overloads. |
docs/code_samples/workflow_execution.txt |
Deletes the obsolete execution sample. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed from server.
Types of changes