Skip to content

🔧 add betterleaks - #451

Merged
ianardee merged 1 commit into
mainfrom
add-betterleaks
Nov 5, 2026
Merged

ianardee merged 1 commit into
mainfrom
add-betterleaks

Conversation

@ianardee

@ianardee ianardee commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Betterleaks scan is not a dependency of the main-branch release chain, allowing version commits to be tagged and released even when the scan detects secrets.

1 open issue
What changed in this PR

This PR adds Betterleaks secret scanning to the repository’s CI workflows and introduces workflow linting for pull requests.

Changes:

  • Add Betterleaks to pull-request and main-branch workflows.
  • Gate pull-request unit tests on secret scanning and static analysis.
  • Standardize main-branch job names and adjust permissions and secret inheritance.
File Description
.github/​workflows/​push-main-branch.yml Adds Betterleaks and renames jobs in the test-to-release chain.
.github/​workflows/​pull-request.yml Adds workflow linting and Betterleaks, updates test dependencies, and removes static-analysis permission overrides.

Review effort: Balanced

Comment thread .github/workflows/push-main-branch.yml Resolved
@ianardee
ianardee force-pushed the add-betterleaks branch 2 times, most recently from 4b24999 to 7ec565d Compare November 5, 2026 16:39
@ianardee
ianardee requested a balanced review from Copilot November 5, 2026 16:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The allowlist matches only Ruby files under spec/, so its AND condition fails to exempt the C# test fixtures containing the dummy key from the new CI scan.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread .betterleaks.toml Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the CI secret-scanning and workflow updates.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@ianardee
ianardee merged commit 4d8c970 into main Nov 5, 2026
14 checks passed
@ianardee
ianardee deleted the add-betterleaks branch November 5, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants