Skip to content

✅ better polling options test - #452

Merged
ianardee merged 1 commit into
mainfrom
update-test
Nov 5, 2026
Merged

ianardee merged 1 commit into
mainfrom
update-test

Conversation

@ianardee

@ianardee ianardee commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the expanded V2 polling-option test coverage and clearer test names.

No open issues 🎉

What changed in this PR

This PR strengthens unit tests for V2 polling options without changing production behavior.

Changes:

  • Adds assertions for default delays, retry count, and millisecond conversions.
  • Adds descriptive display names to the default, custom-value, and invalid-option tests.
File Description
tests/​Mindee.UnitTests/​V2/​ClientOptions/​PollingOptionsTest.cs Adds default-value coverage and clearer test display names.

Review effort: Balanced

@ianardee
ianardee merged commit 235b6c1 into main Nov 5, 2026
31 checks passed
@ianardee
ianardee deleted the update-test branch November 5, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants