Skip to content

✨ add Sort Code on v1 invoice and findoc - #364

Merged
ianardee merged 1 commit into
mainfrom
sort-code
Nov 17, 2026
Merged

ianardee merged 1 commit into
mainfrom
sort-code

Conversation

@ianardee

Copy link
Copy Markdown
Collaborator

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The payment details update misclassifies sort-code-only results as empty and removes a public constructor, breaking source and binary compatibility for SDK consumers.

2 open issues
What changed in this PR

Adds sort-code support to the shared payment-details model used by v1 invoice and financial-document parsing.

Changes:

  • Maps the JSON sort_code property to a new sortCode field.
  • Includes nonempty sort codes in the payment-details string representation.
File Description
src/​main/​java/​com/​mindee/​v1/​parsing/​standard/​PaymentDetailsField.java Adds sort-code storage, constructor mapping, and string output.

Review effort: Balanced

@ianardee
ianardee force-pushed the sort-code branch 2 times, most recently from 0ad9d39 to ae90e00 Compare November 17, 2026 17:53
@ianardee
ianardee requested a balanced review from Copilot November 17, 2026 17:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Replacing the public four-argument PaymentDetailsField constructor breaks source and binary compatibility for SDK clients; the original overload must be retained.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

@ianardee
ianardee merged commit fba668f into main Nov 17, 2026
14 checks passed
@ianardee
ianardee deleted the sort-code branch November 17, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants