Repository navigation
✨ better printing of error messages - #283
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new spec lacks an explicit ErrorItem import, causing isolated runs with nonempty errors to raise NameError before reaching the printing assertion.
1 open issue
What changed in this PR
This PR improves how the V2 parser displays API errors, replacing the compact message with structured, multiline output.
Changes:
- Adds labeled HTTP status, title, code, and detail fields.
- Includes numbered error items with pointers and details when present.
- Adds a fixture-based spec for the formatted output.
| File | Description |
|---|---|
spec/v2/parsing/error_response_spec.rb |
Adds a spec comparing formatted errors with an expected fixture. |
lib/mindee/v2/parsing/error_response.rb |
Formats error responses into readable sections with individual error details. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Types of changes