Skip to content

build: vendor libs3rdma 0.3.3 - #268

Merged
harshavardhana merged 1 commit into
minio:mainfrom
harshavardhana:build/vendor-s3rdma-0.3.3
Oct 27, 2026
Merged

harshavardhana merged 1 commit into
minio:mainfrom
harshavardhana:build/vendor-s3rdma-0.3.3

Conversation

@harshavardhana

Copy link
Copy Markdown
Member

Keeps the vendored client library in step with s3rdma v0.3.3, which aistor ships in miniohq/aistor#8669.

s3rdma_version() is the only runtime signal a consumer gets about the .so next to it. Leaving 0.3.2 here while aistor ships 0.3.3 would let one version number name two different builds.

Not a fix for this repo

The change in 0.3.3 (s3rdma#33) gives each DCI its own flow label, so RDMA traffic to one peer spreads across a bond or ECMP paths. That code is in the server and in libp2p_rdma. The client side this SDK links is unchanged, so this is a consistency refresh.

Contents

The two .so files, x86_64 and aarch64, each reporting 0.3.3. vendor/s3rdma/include/s3rdma.h is already byte-identical to the 0.3.3 header.

Testing

Builds with RDMA enabled against the new libraries.

🤖 Generated with Claude Code

Keeps the vendored client library in step with s3rdma 0.3.3, which
aistor now ships. The behaviour change in 0.3.3, per-DCI flow labels,
is on the server side; the client this SDK links is unaffected.
@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files selected but had no reviewable changes: 2
  • vendor/s3rdma/lib/aarch64/libs3rdma.so.0
  • vendor/s3rdma/lib/x86_64/libs3rdma.so.0
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 932c5da2-439e-4712-8884-bf15de4c5474
Commits

Reviewing files that changed from the base of the PR and between 511edf1 and d571602.

Files selected for processing: 2
  • vendor/s3rdma/lib/aarch64/libs3rdma.so.0
  • vendor/s3rdma/lib/x86_64/libs3rdma.so.0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@harshavardhana
harshavardhana merged commit 3bd5366 into minio:main Oct 27, 2026
18 checks passed
@harshavardhana
harshavardhana deleted the build/vendor-s3rdma-0.3.3 branch October 27, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant