Repository navigation
terminal: close OSC 8 hyperlink in Display::close() and full redraw - #1440
Open
Priyank-gouda678 wants to merge 1 commit into
Open
Priyank-gouda678 wants to merge 1 commit into
Priyank-gouda678 wants to merge 1 commit into
Conversation
SGR 0 does not end an OSC 8 hyperlink, but the full-redraw branch of Display::new_frame() resets current_hyperlink after sending only \033[0m, and Display::close() never ends the link at all. A link the host leaves open therefore stays active on the outer terminal: on a resize or Ctrl-L repaint unrelated cells are drawn inside it, and after mosh-client exits or is suspended the local shell's output becomes a link to the host-chosen URL. Send the OSC 8 terminator before clearing the screen and in close().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SGR 0 does not end an OSC 8 hyperlink, so a link left open by the host (
printf '\e]8;;https://example.com/\e\\') survives the full redraw inDisplay::new_frame()andDisplay::close(): on a resize (including the server's resize diff) or Ctrl-L, unrelated text is redrawn inside the link, and after mosh-client exits or suspends the local shell's output links to the host-chosen URL; send the OSC 8 terminator at both points.