Skip to content

terminal: close OSC 8 hyperlink in Display::close() and full redraw - #1440

Open
Priyank-gouda678 wants to merge 1 commit into
mobile-shell:masterfrom
Priyank-gouda678:osc8-reset-outer-hyperlink
Open

Priyank-gouda678 wants to merge 1 commit into
mobile-shell:masterfrom
Priyank-gouda678:osc8-reset-outer-hyperlink

Conversation

@Priyank-gouda678

Copy link
Copy Markdown

SGR 0 does not end an OSC 8 hyperlink, so a link left open by the host (printf '\e]8;;https://example.com/\e\\') survives the full redraw in Display::new_frame() and Display::close(): on a resize (including the server's resize diff) or Ctrl-L, unrelated text is redrawn inside the link, and after mosh-client exits or suspends the local shell's output links to the host-chosen URL; send the OSC 8 terminator at both points.

SGR 0 does not end an OSC 8 hyperlink, but the full-redraw branch of
Display::new_frame() resets current_hyperlink after sending only
\033[0m, and Display::close() never ends the link at all.  A link the
host leaves open therefore stays active on the outer terminal: on a
resize or Ctrl-L repaint unrelated cells are drawn inside it, and after
mosh-client exits or is suspended the local shell's output becomes a
link to the host-chosen URL.

Send the OSC 8 terminator before clearing the screen and in close().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant