Skip to content

swarmd: remove archived go-grpc-prometheus dependency - #3310

Draft
thaJeztah wants to merge 1 commit into
moby:masterfrom
thaJeztah:swarmd_rm_grpc_prometheus
Draft

thaJeztah wants to merge 1 commit into
moby:masterfrom
thaJeztah:swarmd_rm_grpc_prometheus

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

swarmd: remove archived go-grpc-prometheus dependency

Temporarily disable the optional handling-time histograms in swarmd,
as the new provider requires configuring them at collector creation.
Enabling them globally would introduce additional overhead for SwarmKit
consumers such as Docker Engine.

- How I did it

- How to test it

- Description for the changelog

@codecov-commenter

codecov-commenter commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.69%. Comparing base (323aa0b) to head (48fb333).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3310      +/-   ##
==========================================
- Coverage   14.71%   14.69%   -0.03%     
==========================================
  Files         198      199       +1     
  Lines       93037    93038       +1     
==========================================
- Hits        13693    13672      -21     
- Misses      77997    78030      +33     
+ Partials     1347     1336      -11     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Temporarily disable the optional handling-time histograms in swarmd,
as the new provider requires configuring them at collector creation.
Enabling them globally would introduce additional overhead for SwarmKit
consumers such as Docker Engine.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztah force-pushed the swarmd_rm_grpc_prometheus branch from 9b576b2 to 48fb333 Compare November 2, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants