Skip to content

fix(skills): prevent symlink swaps during catalog loads #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsarlandie-oai wants to merge 2 commits into
base: main
Choose a base branch
from
+324 −52
Open

fix(skills): prevent symlink swaps during catalog loads #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a39b2f6
fix(skills): prevent symlink swaps during catalog loads
tsarlandie-oai Nov 7, 2026
ab66e0b
fix(skills): isolate changed entries during catalog reloads
tsarlandie-oai Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/rmcp/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ sha2 = "0.11"
yaml_serde = { version = "0.10", optional = true }
# reads the `skills-fs` catalog through a root handle that cannot escape it
cap-std = { version = "4", optional = true }
cap-fs-ext = { version = "4", optional = true }

# for SEP-2322 requestState integrity sealing (opt-in via the `request-state` feature)
hmac = { version = "0.13", optional = true }
Expand Down Expand Up @@ -134,6 +135,9 @@ chrono = { version = "0.4.38", default-features = false, features = [
[target.'cfg(unix)'.dependencies]
libc = "0.2"

[target.'cfg(windows)'.dependencies]
windows-sys = { version = "0.61", features = ["Win32_Foundation"], optional = true }

[features]
default = ["base64", "macros", "server"]
local = ["rmcp-macros?/local"]
Expand All @@ -144,7 +148,7 @@ elicitation = ["dep:url"]

# SEP-2322 requestState integrity helper (HMAC-SHA256 seal/open codec)
request-state = ["dep:hmac", "dep:zeroize", "base64"]
skills-fs = ["server", "base64", "dep:cap-std", "dep:yaml_serde"]
skills-fs = ["server", "base64", "dep:cap-std", "dep:cap-fs-ext", "dep:yaml_serde", "dep:windows-sys"]

# reqwest http client
__reqwest = ["dep:reqwest"]
Expand Down
Loading
Loading