Repository navigation
Conversation
The tsdown declaration bundler dropped computed keys on RequestMetaEnvelope
in the 2.4.0 publish, so the type shipped as {} and indexing
ctx.mcpReq.envelope with CLIENT_CAPABILITIES_META_KEY failed with TS7053.
Write the envelope keys as string literals (still a type alias) so the
published .d.ts keeps the wire shape, pin the keys to the public constants
in a type test, and cover the consumer pattern in smoke-dist-types.
Fixes modelcontextprotocol#3171
🦋 Changeset detectedLatest commit: 613276e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3171.
In
@modelcontextprotocol/server2.4.0,RequestMetaEnvelopeis published as{}(seedist/mcp-DbUPMDd5.d.ctsanddist/mcp-BCJHyo7l.d.mts). The source type is keyed by the public meta-key constants ([CLIENT_CAPABILITIES_META_KEY], …). The tsdown declaration bundler dropped those computed keys, so a handler cannot read the envelope without a cast:The v2.4.0 source of this type is the same as current
main. A local tsdown 0.18.4 build happens to keep the computed key names, but that still depends on the bundler not dropping them again.This change writes the envelope keys as the wire string literals (the type stays a
typealias, not an interface, so it remains assignable to_meta's string-indexed slot). Afterpnpm build:all, the published.d.tscontains:So
ctx.mcpReq.envelope?.[CLIENT_CAPABILITIES_META_KEY]is typed asClientCapabilities | undefined.Tests
packages/core-internal/test/types/requestMetaEnvelope.test.tspins the literal keys to the public meta-key constants, so the two cannot drift.scripts/smoke-dist-types.mjs(run in CI afterbuild:all) now compiles the issue's consumer pattern against the built declarations, for both the ESM and CommonJS consumers. The same check fails with TS7053 against the published 2.4.0 typings.How I verified
pnpm build:allpackages/server/dist/mcp-*.d.mtsand*.d.ctsfor the keyedRequestMetaEnvelope(not{})node scripts/smoke-dist-types.mjspnpm typecheck:allpnpm lint:allpnpm test:all