Repository navigation
PYTHON-6193 Add ServerDescription filter to test.test_client.TestClie… - #3147
Merged
Merged
Conversation
…nt.test_continuous_network_errors
NoahStapp
requested review from
aclark4life
and
a balanced review from Copilot
October 26, 2026 20:51
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test changes match the intended endpoint and strengthen the existing regression check without identified blocking issues.
No open issues 🎉
What changed in this PR
This test-only change makes the network-error memory-leak regression check more precise by excluding ServerDescription objects for unrelated endpoints.
Changes:
- Count only descriptions matching the test endpoint,
("invalid", 27017). - Tighten the allowed count delta from 30 to 10 and update the illustrative assertion comment.
| File | Description |
|---|---|
test/test_client.py |
Mirrors the endpoint filter and tighter threshold in the generated synchronous test. |
test/asynchronous/test_client.py |
Adds endpoint filtering and tightens the asynchronous regression check. |
Review effort: Balanced
aclark4life
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nt.test_continuous_network_errors
PYTHON-6193
Changes in this PR
Add a filter to
test_continuous_network_errorsto only countServerDescriptionscreated by the test's client. Shrink the allowed delta to catch regressions more accurately.Test Plan
Existing test change.
Checklist
Checklist for Author
Checklist for Reviewer