Repository navigation
PYTHON-5474 Wait until all mongoses are discovered for mongos retry tests - #3153
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow test changes use existing bounded polling helpers, and no unresolved issues were identified.
No open issues 🎉
What changed in this PR
This PR reduces discovery-related flakiness in PyMongo’s sharded-cluster retry tests by waiting for all configured mongoses before exercising retry behavior.
Changes:
- Add discovery waits to asynchronous retryable-read and retryable-write tests.
- Mirror the waits in generated synchronous tests.
- Remove unused
osimports from retryable-read test files.
| File | Description |
|---|---|
test/test_retryable_writes.py |
Mirrors the mongos discovery wait for synchronous write retries. |
test/test_retryable_reads.py |
Mirrors the read-retry discovery wait and removes an unused import. |
test/asynchronous/test_retryable_writes.py |
Awaits all mongoses before testing write retries. |
test/asynchronous/test_retryable_reads.py |
Awaits all mongoses before testing read retries and removes an unused import. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5474
Changes in this PR
Make retryable read and retryable write tests that require connecting to all mongoses in a cluster execute operations only after all mongoses are discovered.
Test Plan
Existing test changes.
Checklist
Checklist for Author
Checklist for Reviewer