Repository navigation
PYTHON-6200 Wait for monitor threads/tasks to finish in test_close_cl… - #3159
Merged
Merged
Conversation
NoahStapp
requested review from
sleepyStick
and
a balanced review from Copilot
October 28, 2026 19:02
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the changes that wait for background monitors before checking socket cleanup.
No open issues 🎉
What changed in this PR
This PR reduces timing-related failures in test_close_closes_sockets by waiting for background monitors to finish before checking cleanup.
Changes:
- Join the server and round-trip-time monitor executors with 10-second timeouts before assertions.
- Apply the waits to both asynchronous and generated synchronous tests, with comments marking them as temporary pending PYTHON-1634.
| File | Description |
|---|---|
test/test_client.py |
Adds monitor-thread joins before cleanup assertions. |
test/asynchronous/test_client.py |
Awaits monitor-task joins before cleanup assertions. |
Review effort: Balanced
sleepyStick
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oses_sockets
PYTHON-6200
Changes in this PR
Wait for monitor threads/tasks to finish before asserting in
test_close_closes_sockets.Test Plan
Existing test change.
Checklist
Checklist for Author
Checklist for Reviewer