Skip to content

Keep the macOS OpenSSL search paths out of /tmp #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtrojnar merged 1 commit into from
Nov 5, 2026
Merged

Keep the macOS OpenSSL search paths out of /tmp #528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ jobs:
uses: actions/cache@v6
with:
path: "${{env.OPENSSL_PREFIX}}"
key: openssl-${{ env.OPENSSL_VERSION }}-static-${{ matrix.arch }}-macos${{ env.MACOSX_DEPLOYMENT_TARGET }}
key: openssl-${{ env.OPENSSL_VERSION }}-static-${{ matrix.arch }}-macos${{ env.MACOSX_DEPLOYMENT_TARGET }}-usr-local
- name: Build OpenSSL
if: steps.cache-openssl.outputs.cache-hit != 'true'
shell: sh
Expand All @@ -216,13 +216,16 @@ jobs:
tar xf openssl.tar.gz
cd "openssl-${OPENSSL_VERSION}"
# no-module => legacy provider is compiled into libcrypto.a (no dlopen).
# Use the macOS system OpenSSL directory rather than a path that only
# exists on the build machine.
# Keep the default /usr/local prefix and stage the installation with
# DESTDIR: the prefix is compiled in as the engine and provider search
# path, so it must not be a directory like /tmp that any local user
# can write. Use the macOS system OpenSSL directory for the same
# reason.
./Configure "darwin64-${{ matrix.osx_arch }}-cc" \
no-shared no-module no-tests no-docs \
--prefix="${{env.OPENSSL_PREFIX}}" --libdir=lib --openssldir=/etc/ssl
--libdir=lib --openssldir=/etc/ssl
make -j"$(sysctl -n hw.ncpu)"
make install_sw
make install_sw DESTDIR="${{env.OPENSSL_PREFIX}}"

# Setup xcode build environment
- name: Install Xcode (macOS)
Expand Down Expand Up @@ -262,7 +265,7 @@ jobs:
-DCMAKE_INSTALL_PREFIX="$GITHUB_WORKSPACE/dist" \
-DCMAKE_OSX_ARCHITECTURES="${{ matrix.osx_arch }}" \
-DCMAKE_OSX_DEPLOYMENT_TARGET="${{env.MACOSX_DEPLOYMENT_TARGET}}" \
-DOPENSSL_ROOT_DIR="${{env.OPENSSL_PREFIX}}" \
-DOPENSSL_ROOT_DIR="${{env.OPENSSL_PREFIX}}/usr/local" \
-DZLIB_ROOT="${{env.ZLIB_PREFIX}}" \
-DZLIB_USE_STATIC_LIBS=TRUE \
-DOPENSSL_USE_STATIC_LIBS=TRUE
Expand All @@ -286,6 +289,10 @@ jobs:
echo "::error::binary links a non-system dylib"
exit 1
fi
if strings "$bin" | grep -F "${OPENSSL_PREFIX}"; then
echo "::error::binary refers to the OpenSSL staging directory"
exit 1
fi
if ! "$bin" --version | grep -q "OpenSSL ${OPENSSL_VERSION} "; then
"$bin" --version
echo "::error::binary does not use the OpenSSL ${OPENSSL_VERSION} built above"
Expand Down
Loading