Repository navigation
Save release dependency caches straight after building - #529
Merged
Merged
Conversation
The macOS and Windows release jobs cached their zlib and OpenSSL builds with the combined actions/cache action, which saves in a post-job step and only when the whole job succeeds. A later failure, such as a failing test or the fail-fast cancellation of the other matrix job, discarded a fresh build, and the next attempt had to repeat it. Split each cache into a restore step and a save step that runs straight after the corresponding build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The macOS and Windows release jobs cache their zlib and OpenSSL builds with the combined
actions/cacheaction. It saves in a post-job step, and only if the whole job succeeds. Any later failure, such as a failing test or the fail-fast cancellation of the other matrix job, throws away a fresh OpenSSL build, which takes about 8–10 minutes on Windows.Fix
Split each cache into
actions/cache/restorebefore the build andactions/cache/saveright after it.Validation
I ran the workflow via
workflow_dispatchfrom a temporary branch.