Repository navigation
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Roberto Guido <info@madbob.org>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
GVodyanov
left a comment
There was a problem hiding this comment.
Hey! Thanks for the contribution and sorry for the delay, I think this makes sense
While searching, contact's contents are here also tested on a "normalized" form with no diacritics.
normalize() function provides to decompose all composed characters (those involving accents). Combining chars are then removed, to obtain the flat clean version of the content.
The function works both matching accented contents on a non-accented search query ("Álvaro" matches when looking for "alvaro") and skipping non-accented contents on an accented search query (if "André" is explicitely searched, it doesn't match with "Andrea").
Fixes #4064