Skip to content

fix: normalize diacritics on search - #5763

Open
madbob wants to merge 3 commits into
nextcloud:mainfrom
madbob:issue_4064
Open

madbob wants to merge 3 commits into
nextcloud:mainfrom
madbob:issue_4064

Conversation

@madbob

@madbob madbob commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

While searching, contact's contents are here also tested on a "normalized" form with no diacritics.

normalize() function provides to decompose all composed characters (those involving accents). Combining chars are then removed, to obtain the flat clean version of the content.

The function works both matching accented contents on a non-accented search query ("Álvaro" matches when looking for "alvaro") and skipping non-accented contents on an accented search query (if "André" is explicitely searched, it doesn't match with "Andrea").

Fixes #4064

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/ContactsList.vue 0.00% 6 Missing ⚠️
src/models/contact.js 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: Roberto Guido <info@madbob.org>
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@GVodyanov GVodyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the contribution and sorry for the delay, I think this makes sense

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search using letters without diacritics (unaccented) doesn't show contacts containing letters with diacritics (accented) in results.

2 participants