Repository navigation
[stable5.4] fix(a11y): use role group for ranking lists container - #3863
Merged
Merged
Conversation
The submit-mode ranking question wrapped two inner lists in a container with role="list" even though it is not a list itself. Change the outer container to role="group", keep the named inner lists, and add an explicit role="list" so WebKit exposes them as lists despite missing list markers. The ranked list only gets the role while populated to avoid an empty list role. Add a Playwright regression test asserting the group, the list names and the explicit roles. Signed-off-by: yashgill-10 <yashgill-10@users.noreply.github.com>
AndyScherzinger
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #3842