Repository navigation
feat: confirm interactive package manager auto-pinning - #918
Closed
Aschenbath wants to merge 1 commit into
Closed
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Contributor
|
This account has opened more than 10 PRs in the last 24 hours. This looks like bot activity, and will result in a ban if the behavior continues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With COREPACK_ENABLE_AUTO_PIN=1, running a package manager can currently modify an existing package.json without confirmation. Ask before adding packageManager when stdin is a terminal and CI is unset, showing the target manifest and resolved version. Only y/yes accepts; refusal, empty input, or EOF leaves the manifest unchanged and still runs the requested command.
Explicitly enabled auto-pinning remains automatic for CI and non-interactive input. The README documents both modes.
Validation on Node.js 24.20.0:
The local test runner isolates inherited proxy settings from CLI fixtures while retaining proxy access for the live npm-key check. Temporary fixtures use /var/tmp and compilation caches are disabled because /tmp is capacity-constrained. No tests were skipped or modified for these environment adjustments.
Closes #691.
Implementation and automated validation were performed by Codex.