Repository navigation
fix: route Yarn registry tarballs through the configured npm mirror - #924
Closed
Aschenbath wants to merge 1 commit into
Closed
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Contributor
|
This account has opened more than 10 PRs in the last 24 hours. This looks like bot activity, and will result in a ban if the behavior continues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a custom npm registry advertises a Yarn Classic tarball on
registry.yarnpkg.com, Corepack currently downloads from that public host instead of the configured mirror. This breaks installs where public registries are blocked and prevents mirror credentials from reaching the download.This change applies
COREPACK_NPM_REGISTRYto tarball URLs on bothregistry.npmjs.organdregistry.yarnpkg.com, including explicit package-manager URLs. It compares URL origins, preserves package paths and query strings, supports registry base paths and trailing slashes, and documents the behavior. Regression tests cover Basic, Bearer, and proxy authentication for both tarball hosts, along with unrelated origins and scoped paths.Validation:
tsc --noEmit, andeslint --max-warnings=0passed.NOCK_ENV=replay. A local, uncommitted setup file enables this sandbox's outbound proxy only for the live npm signing-key check; inherited proxy variables are cleared for the local registry fixtures.Closes #753.