Repository navigation
feat: reuse registry-scoped npmrc authentication - #925
Closed
Aschenbath wants to merge 1 commit into
Closed
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Contributor
|
This account has opened more than 10 PRs in the last 24 hours. This looks like bot activity, and will result in a ban if the behavior continues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corepack can fetch package-manager metadata and tarballs using registry-scoped credentials already present in npm configuration, so authenticated registries no longer require duplicating credentials in Corepack-specific environment variables.
.npmrcauthentication, including user-config path overrides,_authToken,_auth,username/ base64_password, and environment-variable interpolation. Project settings override user settings and the most specific matching registry path wins.COREPACK_NPM_TOKENand completeCOREPACK_NPM_USERNAME/COREPACK_NPM_PASSWORDtaking precedence.Validation:
node node_modules/typescript/bin/tsc --noEmitnode node_modules/eslint/bin/eslint.js --max-warnings=0env -u NODE_USE_ENV_PROXY -u http_proxy -u https_proxy -u all_proxy -u no_proxy NOCK_ENV=replay node node_modules/vitest/vitest.mjs run --exclude tests/config.test.ts --retry=0 --reporter=verbose: 8 files passed, 237 tests passed and 1 existing expected failure.env -u http_proxy -u https_proxy -u all_proxy -u no_proxy NODE_USE_ENV_PROXY=1 NOCK_ENV=replay node node_modules/vitest/vitest.mjs run tests/config.test.ts --retry=0 --reporter=verbose: 1 file and 1 test passed.The complete suite is run using the repository's existing node_modules in two invocations because this machine requires a proxy for the live npm-key check, while the offline tests use deliberately invalid proxy URLs that Node rejects at startup with
NODE_USE_ENV_PROXY=1. Inherited lowercase proxy variables are removed so the proxy-specific cases use their own local proxy. All 9 test files and 239 test cases are included, with retries disabled.Closes #756