Repository navigation
fix(download): add Windows support for fnm - #9252
Merged
Merged
Conversation
Use the WIN key for fnm compatibility and add a shell env setup step to the fnm snippet so fnm and node are usable without restarting the shell. Signed-off-by: bmuenzenmeyer <brian.muenzenmeyer@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9252 +/- ##
==========================================
+ Coverage 86.09% 86.12% +0.03%
==========================================
Files 87 87
Lines 6149 6164 +15
Branches 369 369
==========================================
+ Hits 5294 5309 +15
Misses 851 851
Partials 4 4 ☔ View full report in Codecov by Harness. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The fnm instructions leave PATH and persistent shell-setup gaps on fresh installations and do not ensure the selected Node.js release is activated.
4 open issues
What changed in this PR
Restores fnm as a Windows installation option on the download page and adds shell initialization intended to address the failure reported in #7487.
Changes:
- Adds Windows to fnm’s supported operating systems.
- Adds PowerShell and macOS/Linux environment initialization before installing Node.js.
| File | Description |
|---|---|
apps/site/util/download/constants.json |
Enables the fnm option for Windows. |
apps/site/snippets/en/download/fnm.bash |
Adds OS-specific fnm shell initialization. |
Review effort: Balanced
Contributor
📦 Build Size ComparisonSummary
Changes🔄 Modified Routes (4)
|
Signed-off-by: bmuenzenmeyer <brian.muenzenmeyer@gmail.com>
AugustinMauroy
approved these changes
Oct 31, 2026
ovflowd
approved these changes
Oct 31, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Discussed as an action item out of nodejs/web-team#191 - I don't recall any blockers, and this is what I use on my Windows machine. It's superior to the current production Docker default.
Re-enables fnm as an install method on Windows.
WINOS key for fnm inconstants.jsonfnm env --use-on-cd --shell powershell | Out-String | Invoke-Expressioneval "$(fnm env)"Validation
Tested on Windows in PowerShell. Note: fnm 1.37.0 and 1.37.1 only accept
--shell power-shell. Schniz/fnm#1264 fixed this in 1.37.2, and current releases acceptpowershellas documented in fnm's README.Related Issues
Refs #7487, #7769
Assisted-by: a frontier model