Repository navigation
fix: reject deepObject integers that overflow the destination - #185
Merged
mromaszewicz merged 1 commit intoNov 16, 2026
Merged
Conversation
assignPathValues parsed integers as int64 and called SetInt without an OverflowInt check, so 200 bound to an int8 field as -56. The form style and the JSON binders already return an overflow error.
mromaszewicz
approved these changes
Nov 16, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnmarshalDeepObjectparses integer fields withstrconv.ParseInt(v, 10, 64)and callsSetIntwithout checking that the value fits, so an out-of-range value wraps silently:The form style already rejects the same value with this message (
bindstring.go), and the JSON binders checkOverflowIntas well. This adds the same check to the deepObject int case.The new test binds values at the int8 and int32 bounds and one past them; the overflow rows fail without the change.
go test -race ./...,go vetandgolangci-lint runpass.Written with AI assistance (Claude); I have reviewed the change.