You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A slight regression: when we have an inset on a scale, and the line option is set, the line used to start at the inset; now it starts at the frame. (None of the existing tests has that configuration, but there was one in this branch.)
I think it should be possible to propagate the scale’s insets to the implicit frame mark used to draw the line. I’m not totally sure we should do this, though, because I think the idea of the line option is that it draws the edge of the frame, not the edge of the scale domain/range.
More concretely, if we had an automatic frame for facets #1251 would you expect that to behave the same as a default Plot.frame, or to likewise respect the scales’ insets?
Activity
mbostock commentedon Feb 6, 2023
I think it should be possible to propagate the scale’s insets to the implicit frame mark used to draw the line. I’m not totally sure we should do this, though, because I think the idea of the line option is that it draws the edge of the frame, not the edge of the scale domain/range.
More concretely, if we had an automatic frame for facets #1251 would you expect that to behave the same as a default Plot.frame, or to likewise respect the scales’ insets?
Fil commentedon Feb 6, 2023
Yeah, I'm agnostic about this question. I just didn't want it to slip under the radar.
I like the argument with Plot.frame, since in that case it's clear we don't want to inset the frame.
Closing as wontfix