Skip to content

PDP11: Fix NG device SET SCALE. - #651

Open
larsbrinkhoff wants to merge 1 commit into
open-simh:masterfrom
larsbrinkhoff:lars/ng-set-scale
Open

larsbrinkhoff wants to merge 1 commit into
open-simh:masterfrom
larsbrinkhoff:lars/ng-set-scale

Conversation

@larsbrinkhoff

Copy link
Copy Markdown
Contributor

If the device has opened a window, the scale can't be changed. This fixes the incorrect check against UNIT_DIS and improves error messages. Thanks to @markpizz for reporting the bug in #643

If the device has opened a window, the scale can't be changed.
@markpizz

Copy link
Copy Markdown
Contributor

You might want to include the (r != SCPE_OK) in the test before the reject reason, otherwise a bad numeric input won't have any explanation about the problem...

  if ((r != SCPE_OK) ||
+      (v != 1 && v != 2 && v != 4 && v != 8))
+      return sim_messagef (SCPE_ARG, "Scale can only be: 1, 2, 4, or 8, not: %s\n", cptr);

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants