Repository navigation
PDP11: Fix NG device SET SCALE. - #651
Open
larsbrinkhoff wants to merge 1 commit into
Open
larsbrinkhoff wants to merge 1 commit into
larsbrinkhoff wants to merge 1 commit into
Conversation
If the device has opened a window, the scale can't be changed.
Contributor
|
You might want to include the (r != SCPE_OK) in the test before the reject reason, otherwise a bad numeric input won't have any explanation about the problem... |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the device has opened a window, the scale can't be changed. This fixes the incorrect check against UNIT_DIS and improves error messages. Thanks to @markpizz for reporting the bug in #643