Repository navigation
Count data points in OTLP metric exporter health metrics - #9016
Open
goutamadwant wants to merge 3 commits into
Open
goutamadwant wants to merge 3 commits into
goutamadwant wants to merge 3 commits into
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-11-10 09:33 UTC Investigate required status check failures. Status above doesn't look right?
|
Give the HTTP and gRPC metric exporter builder fixtures one data point so their meter-provider tests retain meaningful nonzero assertions. Cover legacy and latest exporter instrumentation in both memory modes, including multi-point and empty exports, asynchronous success and failure, and subsequent exports. Assert that legacy seen/exported counters count data points and preserve their type and success attributes, with exported counts updated only after completion.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9016 +/- ##
============================================
+ Coverage 90.37% 90.46% +0.09%
- Complexity 11018 11024 +6
============================================
Files 1021 1021
Lines 30124 30128 +4
Branches 3933 3935 +2
============================================
+ Hits 27225 27256 +31
+ Misses 1941 1915 -26
+ Partials 958 957 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9011.
Count the data points across the exported metrics when recording exporter health metrics. Previously, a batch containing three instruments with 3, 2, and 0 points reported 3 items instead of 5. Both reusable and immutable memory modes now pass the point count to the exporter instrumentation.
The regression test checks inflight and exported counts before and after asynchronous success or failure, including empty metrics, empty batches, and subsequent exports.
Validation:
./gradlew :exporters:otlp:common:check :exporters:common:check./gradlew :exporters:otlp:all:testOkHttpVersionLATEST --tests '*MetricExporter*'