[harshiniiiiiii]

What

Removes the legacy "Show Closed Accounts" toggle from the Clients list (WEB-1341). A dedicated Status dropdown is now the single status-filtering control.

Why

The toggle was redundant with the Status dropdown (Pending / Active / Closed / Rejected). Investigation showed toggleShowClosed() only flipped showClosedAccounts and that flag was never passed to searchByText() nor used in any filtering, so the control was already non-functional.

Changes

• src/app/clients/clients.component.html — removed the toggle markup.
• src/app/clients/clients.component.ts — removed showClosedAccounts state and toggleShowClosed().
• src/app/clients/clients.component.spec.ts — added tests: toggle no longer rendered, Status dropdown retained, closed clients returned by the server are still rendered.
• src/assets/translations/*.json (14 locales) — removed the now-unused labels.inputs.Show Closed Accounts key. labels.buttons.Show Closed Accounts is kept because the Loans list and the client general tab still use it.
• playwright/config/selectors.ts, playwright/pages/clients-list.page.ts — removed the unreferenced toggle selector and helper.

The Status dropdown, its filtering, search, sorting, pagination, counts, loading and empty states are unchanged.

Testing

• jest src/app/clients/clients.component.spec.ts — 29/29 passed.
• jest src/app/clients — 38 suites, 404 tests passed.
• npm run lint — passed.
• npm run build (production) — passed.
• Prettier, ESLint, HTMLHint, file-header check, git diff --check — passed.

Screenshots

Before

After

Summary by CodeRabbit

• Changes

  • Removed the “Show Closed Accounts” toggle from the clients list.
  • Closed clients are now displayed when no status filter is selected.
  • The existing status filter remains available for narrowing the client list.

• Tests

  • Added coverage confirming the toggle is absent, the status filter remains available, and closed clients appear without a selected status filter.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

• Last reviewed commit: 5d58781
• Latest commit, not reviewed: fdf15ab

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

Parsing warnings: 1

Validation error: Unrecognized key: "pre_merge_checks"

Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review.

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: openMF/web-app/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 55b1ad89-8f93-4952-ad75-02493e2c6fd7

📥 Commits

Reviewing files that changed from the base of the PR and between 0507452 and 5d58781.

📒 Files selected for processing: 14

• src/assets/translations/az-AZ.json
• src/assets/translations/cs-CS.json
• src/assets/translations/de-DE.json
• src/assets/translations/en-US.json
• src/assets/translations/es-CL.json
• src/assets/translations/es-MX.json
• src/assets/translations/fr-FR.json
• src/assets/translations/it-IT.json
• src/assets/translations/ko-KO.json
• src/assets/translations/lt-LT.json
• src/assets/translations/lv-LV.json
• src/assets/translations/ne-NE.json
• src/assets/translations/pt-PT.json
• src/assets/translations/sw-SW.json

💤 Files with no reviewable changes: 14

• src/assets/translations/de-DE.json
• src/assets/translations/es-MX.json
• src/assets/translations/it-IT.json
• src/assets/translations/sw-SW.json
• src/assets/translations/lt-LT.json
• src/assets/translations/lv-LV.json
• src/assets/translations/ne-NE.json
• src/assets/translations/fr-FR.json
• src/assets/translations/cs-CS.json
• src/assets/translations/en-US.json
• src/assets/translations/es-CL.json
• src/assets/translations/pt-PT.json
• src/assets/translations/ko-KO.json
• src/assets/translations/az-AZ.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The client list removes the “Show Closed Accounts” toggle and its component state. The status filter remains. Playwright support and translation entries for the toggle are removed. Tests cover the remaining filter and unfiltered results that include a closed client.

Changes

Client List Toggle Removal

Layer / File(s)	Summary
Remove the client-list toggle src/app/clients/clients.component.ts, src/app/clients/clients.component.html, src/app/clients/clients.component.spec.ts, src/assets/translations/*	The component removes the toggle and its state. Tests check that the toggle is absent, the status filter remains, and an unfiltered response displays a closed client. The corresponding translation entries are removed.
Remove Playwright toggle support playwright/config/selectors.ts, playwright/pages/clients-list.page.ts	The selector contract and page object remove the toggle locator and action.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: devvaansh

Merge Risk: Minimal · previous review 5d587

The removed Clients toggle does not leave a known missing translation. No issue identified here prevents merging after normal checks.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: removal of the legacy Show Closed Accounts toggle from the Clients list.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}