Repository navigation
WEB-1398: Show the Configuration Wizard popovers for Global Configurations and Scheduler Jobs - #4225
Conversation
…tions and Scheduler Jobs
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
 |
| Layer / File(s) | Summary |
|---|---|
Add navigation wrappers src/app/system/system.component.html |
Manage Jobs and Configurations are each enclosed in a div with a template reference. Their existing navigation content and controls are unchanged. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested reviewers: adamsaghy, syedmahmood777
Merge Risk: 
56dac
-
This focused template change is ready to merge and should restore the affected configuration wizard popovers.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the fix for Configuration Wizard popovers on Global Configurations and Scheduler Jobs. It matches the main change in the pull request. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❌ Too many commitsThis PR has 2 commits — it must have exactly 1. How to squash# From your PR branch:
git rebase -i HEAD~2
# In the editor that opens, keep the FIRST commit as "pick"
# and change all others to "squash" (or "s"):
# pick abc1234 Your first commit message
# squash def5678 Your second commit
# squash ghi9012 Your third commit
# Save, then edit the combined commit message.
# Finally, force-push:
git push --force-with-lease
|
Description
On the System page, two Configuration Wizard steps never show their popover:
The browser console shows a TypeError in both cases.
system.component.tsreads#configurationsand#schedulerJobswith@ViewChild, but those template references were dropped fromsystem.component.htmlin a09853c, so the popover has no element to attach to.This wraps the Manage Jobs and Configurations menu items in
<div #schedulerJobs>and<div #configurations>, the same way#manageReportsis wrapped. The rest of the diff is prettier re-indenting the wrapped lines; with whitespace ignored the change is four lines.Related issues and discussion
Jira: https://mifosforge.jira.com/browse/WEB-1398
Slack: https://mifos.slack.com/archives/CJJGJLN10/p1793418615209899
Screenshots, if any
Before:
After:
Checklist
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit