Repository navigation
WEB-1400: Translate the Close button on the Manage Funds and Charges wizard popovers - #4227
Conversation
|
Caution Review failedThe pull request is closed. Note
|
| Layer / File(s) | Summary |
|---|---|
Use translated Close labels src/app/organization/manage-funds/manage-funds.component.html, src/app/products/products.component.html |
The manage-funds and Charges popover Close buttons use labels.buttons.Close. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Suggested reviewers: adamsaghy
Merge Risk: 
ad02a
-
The requested Close-button localization is implemented in both affected popovers and is ready to merge.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: translating the Close buttons in the Manage Funds and Charges wizard popovers. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
|
@Gautam-Bharadwaj Please rebase on the latest dev and push again. |
ad02acf to
d42cc52
Compare
|
Done, rebased on the latest dev and pushed. Thanks @YousufFFFF |
|
LGTM! |
❌ Too many commitsThis PR has 2 commits — it must have exactly 1. How to squash# From your PR branch:
git rebase -i HEAD~2
# In the editor that opens, keep the FIRST commit as "pick"
# and change all others to "squash" (or "s"):
# pick abc1234 Your first commit message
# squash def5678 Your second commit
# squash ghi9012 Your third commit
# Save, then edit the combined commit message.
# Finally, force-push:
git push --force-with-lease
|
Description
The Close button on two Configuration Wizard popovers is hardcoded in English: the Manage Funds popover (Setup Funds) and the Charges popover (Setup Products). With the language set to Spanish or any other language, the other buttons are translated but Close stays in English.
Every other wizard popover uses the labels.buttons.Close key with the translate pipe. This change does the same in manage-funds.component.html and products.component.html. The key already exists in all translation files, so no translation changes are needed.
Related issues and discussion
Jira: https://mifosforge.jira.com/browse/WEB-1400
Slack: https://mifos.slack.com/archives/CJJGJLN10/p1793418615209899
Screenshots, if any
Before:
After:
Checklist
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit