Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1071
When a model preview textdraw shows a vehicle and the colours were never set, the server keeps them as -1 and sends -1 to the client. The client then picks a random colour from carcols on its own, so the server never knows what is actually shown, and "(Player)TextDrawGetPreviewVehCol" returns "-1, -1". This change makes the server pick the colours instead, using "getRandomVehilceColour" (the same that vehicles use when spawned with -1 colours). The picked colors is what gets sent to clients and what the get returns, so they always match.
Details:
before, each client picked its own random colour on every show, so different players could see different colours on the same global textdraw. Now the colour is picked once per textdraw and everyone sees the same one, which makes more sense to me.
Tested on Windows with latest 1.6.7.3218 realase.