Skip to content

chore(speckit): upgrade Spec Kit to 1.2.5 and opsmill-speckit to 1.4.1 - #1490

Open
polmichel wants to merge 5 commits into
stablefrom
pmi-speckit-1.2-upgrade
Open

polmichel wants to merge 5 commits into
stablefrom
pmi-speckit-1.2-upgrade

Conversation

@polmichel

@polmichel polmichel commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Upgrades Spec Kit from 0.11.9 to 1.2.5 and opsmill-speckit from 1.1.0 to 1.4.1, with the same steps as opsmill/infrahub#11376. Part of opsmill/opsmill-speckit#29.

Changes

  • The spec-kit commands become skills with hyphenated names: /speckit-opsmill-auto replaces /speckit.opsmill.auto.
  • The review extension is removed, because it does not install on Spec Kit 1.x.
  • The checkpoint extension and the critique-opsmill preset are added.
  • The jira-branch preset replaces the infrahub preset.
  • The Claude Code and Codex hooks from opsmill-speckit 1.4.1 run spec-kit with the project's Python, which provides PyYAML.

After the merge

  • In Codex: trust the project hooks.
  • Optional: install the pr-review-toolkit Claude Code plugin for a full review. Without it, the review step uses /code-review.
  • Optional, only to manage extensions: upgrade the specify CLI to 1.2.5.

Tests

Run in clean clones of this branch:

  • The spec-kit scripts ran with the Python that the Claude Code hook selects, and through the Codex hook.
  • In Claude Code, /speckit-opsmill-auto completed every phase on a sample feature, with a system python3 that has no PyYAML.
  • In Codex, the same run reached the implementation report. It could not commit, because the test sandbox denied writes to .git.
  • The two agent runs used earlier copies of the hooks. On this branch, the hooks from opsmill-speckit 1.4.1 set the project's Python for a Claude Code session and rerouted setup-plan.sh for Codex.

Review

Review commit by commit. Spec Kit generated most of the upgrade commit.

🤖 Generated with Claude Code

The agent-context extension that Spec Kit 1.2 ships contains Python that
does not follow the project's rules. `.specify` is in the ruff and ty
exclude lists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: db1ddea
Status: ✅  Deploy successful!
Preview URL: https://58d65636.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pmi-speckit-1-2-upgrade.infrahub-sdk-python.pages.dev

View logs

@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##           stable    #1490      +/-   ##
==========================================
- Coverage   85.18%   85.18%   -0.01%     
==========================================
  Files         148      148              
  Lines       13368    13347      -21     
  Branches     1975     1965      -10     
==========================================
- Hits        11388    11370      -18     
+ Misses       1412     1411       -1     
+ Partials      568      566       -2     
Flag Coverage Δ
integration-tests 39.20% <ø> (+0.26%) ⬆️
python-3.10 58.41% <ø> (+0.07%) ⬆️
python-3.11 58.40% <ø> (+0.06%) ⬆️
python-3.12 58.41% <ø> (+0.07%) ⬆️
python-3.13 58.40% <ø> (+0.06%) ⬆️
python-3.14 58.41% <ø> (+0.07%) ⬆️
python-3.15 58.40% <ø> (+0.06%) ⬆️
python-filler-3.12 23.68% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

polmichel and others added 4 commits November 8, 2026 19:36
Follows the "Upgrading spec-kit to 1.2 or later" steps of opsmill-speckit
v1.4.1, as in opsmill/infrahub#11376:

- remove the review extension, which does not install on Spec Kit 1.x
- upgrade the Claude integration to Spec Kit 1.2.5
- reinstall opsmill from the v1.4.1 tag
- add the checkpoint extension and the critique-opsmill preset
- replace the infrahub Jira preset with jira-branch, and delete
  dev/spec-kit/presets/infrahub
- update agent-context to 1.0.2, the version Spec Kit 1.2.5 ships, and
  keep its CLAUDE.md configuration

No file that the integration manages had local changes, so the forced
upgrade loses nothing.

Also deletes the command files that Spec Kit 0.x generated in
.agents/commands. Spec Kit 1.2 uses the skills in .agents/skills instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on's

The infrahub extension, added in #979, ran speckit.infrahub.feature
before each specification to check the Jira reference in the branch
name. Its command file was removed with the infrahub preset, so the hook
pointed to a command that no longer exists. The jira-branch preset now
does that check in speckit.git.feature, so the hook is the git
extension's, as in opsmill/infrahub#11376.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The upgrade installs presets in .specify/presets, which rumdl checked,
unlike .specify/extensions and .specify/templates. Spec Kit regenerates
these files on each upgrade.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The plan, tasks and template scripts of Spec Kit 1.2 need PyYAML, which
the system python3 often lacks. The Claude Code and Codex hooks that
opsmill-speckit 1.4.1 ships point them at the project environment when it
has PyYAML, and do nothing otherwise.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X9ZEsTmHy1shuNRt88HiUb
@polmichel
polmichel force-pushed the pmi-speckit-1.2-upgrade branch from cb368c6 to db1ddea Compare November 8, 2026 18:39
@polmichel polmichel changed the title chore(speckit): upgrade Spec Kit to 1.2.5 and opsmill-speckit to 1.4.0 chore(speckit): upgrade Spec Kit to 1.2.5 and opsmill-speckit to 1.4.1 Nov 9, 2026
@polmichel
polmichel requested a review from a team November 9, 2026 13:40
@polmichel
polmichel marked this pull request as ready for review November 9, 2026 13:40
@polmichel
polmichel requested a review from a team as a code owner November 9, 2026 13:40
@cubic-dev-ai

cubic-dev-ai Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

This PR has 10,953 reviewable changed lines after ignored/generated files are excluded, above this repository's 10,000-changed-line automatic review limit.

Most of the diff comes from:

  • .specify/extensions/review/tests/pester/detect-changed-files.Tests.ps1 (~740 changed lines)
  • .specify/extensions/review/tests/bats/detect-changed-files.bats (~650 changed lines)
  • .specify/scripts/bash/common.sh (~575 changed lines)
  • .agents/skills/speckit-opsmill-qa/SKILL.md (~371 changed lines)
  • .specify/extensions/opsmill/commands/qa.md (~369 changed lines)

Comment @cubic-dev-ai review this to review it anyway. If the largest files are generated or fixture data, add them to your ignored files in review settings or reviews.ignore.files in cubic.yaml. Later automatic reviews cover only subsequent changes. Request a full review to revisit earlier changes. You can also raise this limit in review settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant